Feature/python 3 #206
Closed
Feature/python 3 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested. Works. |
|
How do I add something on top of your pull request? Please queue patch from https://github.com/keszybz/pelita/tree/pr/206. |
|
No idea. However patching itself is pretty easy: |
|
Closing in favour of #258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing: The Python 3 version of Pelita.
Most went well with 2to3 but a few additional fixes were needed with string conversions (mostly for the socket I/O) and newly introduced name conflicts.
Thanks to our better-than-average coverage, I’m also rather confident that there are not too many bugs left.
Notes:
— The compat.argparse has been retired
— I’ve added a python3 shebang but I’m not sure this is correct and future-proof (e.g. travis complains about it)
Are there any great Python 3 features we could immediately take advantage of?