From f1b299190c384c97793d1aecbf690b7737dcaf15 Mon Sep 17 00:00:00 2001 From: Juan Pablo Mitriatti Date: Mon, 10 Feb 2025 16:35:34 -0300 Subject: [PATCH 1/3] fix(unity-bootstrap-theme): changed height to min-height on hero-overlay classes UDS-1765 --- .../src/scss/extends/_heroes.scss | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss b/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss index 8138e28cf9..92d3780163 100644 --- a/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss +++ b/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss @@ -79,6 +79,7 @@ div[class^="uds-hero"] { grid-row: 2; grid-template-columns: 1fr; grid-template-rows: 1fr 1fr; + margin-top: $uds-size-spacing-10; p { margin: 0; @@ -244,7 +245,7 @@ div.uds-hero-sm { } .hero-overlay { - height: $uds-size-spacing-32; + min-height: $uds-size-spacing-32; } } @@ -270,7 +271,7 @@ div.uds-hero-md { } .hero-overlay { - height: 21rem; + min-height: 21rem; } } @@ -307,7 +308,7 @@ div.uds-hero-lg { } .hero-overlay { - height: $uds-size-spacing-64; + min-height: $uds-size-spacing-64; } } @@ -419,7 +420,7 @@ div.uds-hero-lg { } .hero-overlay { - height: $uds-size-spacing-64; + min-height: $uds-size-spacing-64; } } } @@ -448,7 +449,7 @@ div.uds-hero-lg { } .hero-overlay { - height: 42.75rem; + min-height: 42.75rem; } } From 0e0c04b558758836963fdffc526dbdbe7e793445 Mon Sep 17 00:00:00 2001 From: Juan Pablo Mitriatti Date: Mon, 17 Feb 2025 15:27:39 -0300 Subject: [PATCH 2/3] feat(unity-bootstrap-theme): changed heigth to min-heigth on div.uds-hero-lg UDS-1765 --- .../unity-bootstrap-theme/src/scss/extends/_heroes.scss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss b/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss index 92d3780163..f3dda451ad 100644 --- a/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss +++ b/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss @@ -282,7 +282,7 @@ div.uds-hero-md { } div.uds-hero-lg { - height: $uds-size-spacing-64; + min-height: $uds-size-spacing-64; .content { display: none; @@ -426,7 +426,7 @@ div.uds-hero-lg { } div.uds-hero-lg { - height: 42.75rem; + min-height: 42.75rem; // TODO; remove this, it's a fallback for buttons without has-btn-row grid-template-rows: 1fr repeat(4, auto) $uds-size-spacing-6; @@ -498,7 +498,7 @@ div.uds-hero-lg { } div.uds-hero-lg { - height: 42.75rem; + min-height: 42.75rem; &.uds-video-hero { position: relative; From 64002b904d50c4ae9aee7377327fc9b58425b0cd Mon Sep 17 00:00:00 2001 From: Juan Pablo Mitriatti Date: Mon, 24 Feb 2025 12:04:08 -0300 Subject: [PATCH 3/3] fix(unity-bootstrap-theme): added style for small and medium hero UDS-1765 --- .../unity-bootstrap-theme/src/scss/extends/_heroes.scss | 8 ++++---- .../src/scss/extends/_xx_Hero-Competing.scss | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss b/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss index f3dda451ad..f7e4f5bb58 100644 --- a/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss +++ b/packages/unity-bootstrap-theme/src/scss/extends/_heroes.scss @@ -212,7 +212,7 @@ div[class^="uds-hero"] { } div.uds-hero-sm { - height: $uds-size-spacing-32; + min-height: $uds-size-spacing-32; grid-template-rows: 1fr auto auto 3rem; h1, @@ -255,7 +255,7 @@ div.uds-hero-sm { } div.uds-hero-md { - height: 21rem; + min-height: 21rem; // by design, the hero-md has no content on mobile, change grid template rows and hide .content grid-template-rows: 1fr auto auto 3rem; @@ -379,7 +379,7 @@ div.uds-hero-lg { grid-template-rows: 1fr auto auto $uds-size-spacing-7; &.has-btn-row { .btn-row { - top: 14.5rem; + top: 92%; } } @@ -391,7 +391,7 @@ div.uds-hero-lg { } div.uds-hero-md { - height: $uds-size-spacing-64; + min-height: $uds-size-spacing-64; // TODO; remove this, it's a fallback for buttons without has-btn-row grid-template-rows: 1fr repeat(4, auto) $uds-size-spacing-6; h1 { diff --git a/packages/unity-bootstrap-theme/src/scss/extends/_xx_Hero-Competing.scss b/packages/unity-bootstrap-theme/src/scss/extends/_xx_Hero-Competing.scss index 6cf4e84229..00928b2b4f 100644 --- a/packages/unity-bootstrap-theme/src/scss/extends/_xx_Hero-Competing.scss +++ b/packages/unity-bootstrap-theme/src/scss/extends/_xx_Hero-Competing.scss @@ -61,18 +61,18 @@ div[class^='uds-hero'] { } &.uds-hero-sm { - height: $uds-size-spacing-32; + min-height: $uds-size-spacing-32; .hero-body { display: none; } } &.uds-hero-md { - height: $uds-size-spacing-64; + min-height: $uds-size-spacing-64; } &.uds-hero-lg { - height: 42.75rem; + min-height: 42.75rem; } }