Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WS2-1156: Use yarn for package management. #27

Merged
merged 4 commits into from
Dec 8, 2021
Merged

WS2-1156: Use yarn for package management. #27

merged 4 commits into from
Dec 8, 2021

Conversation

georgebaev
Copy link
Contributor

@duarte-daniela @mlsamuelson this adds yarn as a package manager.

Ref.: https://asudev.jira.com/browse/WS2-1156

@mlsamuelson
Copy link
Collaborator

Perhaps we may want to hold on this one since we also have a ticket to switch to the new component-header instead of components-library?

@georgebaev georgebaev marked this pull request as ready for review November 30, 2021 06:26
@georgebaev
Copy link
Contributor Author

@duarte-daniela @mlsamuelson the events functionality uses the component-events now, could you please review?

mlsamuelson
mlsamuelson approved these changes Dec 2, 2021
View reviewed changes
Copy link
Collaborator

@mlsamuelson mlsamuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks better now that the components-library is out and we're using component-events.

@duarte-daniela duarte-daniela merged commit 090485e into master Dec 8, 2021
@georgebaev georgebaev deleted the WS2-1156 branch December 14, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsamuelson mlsamuelson mlsamuelson approved these changes

@duarte-daniela duarte-daniela Awaiting requested review from duarte-daniela

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgebaev @mlsamuelson @duarte-daniela