- Removed code duplication

AStA-Wedel · Mar 25, 2013 · 2b5ca04 · 2b5ca04
1 parent 7fbc918
commit 2b5ca04
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/main/java/org/fhw/asta/kasse/server/service/CheckoutServiceEndpoint.java b/src/main/java/org/fhw/asta/kasse/server/service/CheckoutServiceEndpoint.java
@@ -20,6 +20,8 @@ public class CheckoutServiceEndpoint extends RemoteServiceServlet implements Che
   private static final long serialVersionUID = 1L;
   private static final Logger LOGGER = Logger.getLogger(CheckoutServiceEndpoint.class);
 
+  private static final String DEFAULT_RECIPIENT = "default";
+
   @Inject
   private UserDao userDao;
 
@@ -33,11 +35,11 @@ public Integer doCheckout(List<BasketItem> items, int discount, String receipien
     final Optional<String> issuerLdapName = new UserLdapNameProvider(this.getThreadLocalRequest()).get();
 
     if (issuerLdapName.isPresent() && this.userDao.exists(issuerLdapName.get())) {
-    	if(this.userDao.exists(receipientLdapName)) {
+
-    		return this.billOrderDao.saveBillOrder(items, discount, receipientLdapName, issuerLdapName.get(), orderState);
+    	String receipient = this.userDao.exists(receipientLdapName) ? receipientLdapName : DEFAULT_RECIPIENT;
-    	} else {
+
-    		return this.billOrderDao.saveBillOrder(items, discount, "default", issuerLdapName.get(), orderState);
+   		return this.billOrderDao.saveBillOrder(items, discount, receipient, issuerLdapName.get(), orderState);
-    	}
+   	 
     } else {
       LOGGER.info("A non registered user tried to checkout");
       throw new CheckoutException("No issuer for checkout given. Are you logged in?");