Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML code generator does not %encode characters in file-name part of URL #313

Closed
leagris opened this issue Feb 7, 2017 · 1 comment
Closed

XML code generator does not %encode characters in file-name part of URL #313

leagris opened this issue Feb 7, 2017 · 1 comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@leagris
Copy link

leagris commented Feb 7, 2017

File names and paths with special characters are not %encoded as per rfc-3986 section 2.1-2.4 for the url attribute.

Example with HelpFixer version="1.4+17"

Generated code is:

<mod
  name="HelpFixer"
  version="1.4+17"
  url="packs/BeyondReality/files/1.11mods/HelpFixer-1.11-1.4+17.jar"
  file="HelpFixer-1.11-1.4+17.jar"
…
/>

but url fails to resolve and it raises an error
image

url should be %coded like this:

<mod
  url="packs/BeyondReality/files/1.11mods/HelpFixer-1.11-1.4%2B17.jar"
…
/>
@stale stale bot added the wontfix The ATLauncher team has decided not to fix these issues for now for some reason. label May 23, 2019
@RyanTheAllmighty RyanTheAllmighty removed wontfix The ATLauncher team has decided not to fix these issues for now for some reason. labels May 25, 2019
@ATLauncher ATLauncher deleted a comment from stale bot May 25, 2019
@RyanTheAllmighty RyanTheAllmighty added enhancement Feature requests. bug Confirmed bugs or reports that are very likely to be bugs. and removed enhancement Feature requests. labels May 25, 2019
@RyanTheAllmighty
Copy link
Member

This has been fixed by the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leagris @RyanTheAllmighty