Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Replace Japanese translation #4953

Closed
1 task done
L4Ph opened this issue Nov 22, 2022 · 8 comments
Closed
1 task done

[Feature Request]: Replace Japanese translation #4953

L4Ph opened this issue Nov 22, 2022 · 8 comments

Comments

@L4Ph
Copy link

L4Ph commented Nov 22, 2022

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

The Japanese translations on the Official Extension index are not very frequent (not keeping up with changes in stable-diffusion-webui), and there is no information on how to use the software, so I would like to see new translations made official.

Proposed workflow

  1. Go to https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Extensions-index
{"name": "ja_JP Localization", "url": "https://github.com/yuuki76/webui-localization-ja_JP", "description": "Japanese localization", "tags": ["localization"] },
  1. Replace the above description with this one
{"name": "ja_JP Localization", "url": "https://github.com/Katsuyuki-Karasawa/stable-diffusion-webui-localization-ja_JP", "description": "Japanese localization", "tags": ["localization"] },

Additional information

I have searched around and found that information on how to change to Japanese is quite sparse.
I don't think it's good for the users if the site is left unmaintained with no readme, etc.

@L4Ph L4Ph changed the title [Feature Request]: Japanese Translation [Feature Request]: Replace Japanese translation Nov 22, 2022
@ClashSAN
Copy link
Collaborator

Submit a PR to https://github.com/yuuki76/webui-localization-ja_JP with your changes, and ask @yuuki76 for collaborator access on his repository, so you can make changes there, without approval. If there's no response, we can add it

@L4Ph
Copy link
Author

L4Ph commented Nov 23, 2022

ok i understand
I threw a pull request for now.
krisfail/webui-localization-ja_JP#1 (comment)

@ClashSAN
Copy link
Collaborator

@Katsuyuki-Ka updated the extensions index now, you can invite yuuki76 as collaborator to your repository

@L4Ph
Copy link
Author

L4Ph commented Nov 24, 2022

@ClashSAN
Should I close the PR over here?
krisfail/webui-localization-ja_JP#1

@ClashSAN
Copy link
Collaborator

sure, i think he's just busy

@L4Ph
Copy link
Author

L4Ph commented Nov 24, 2022

ok closed
I will do my best to continue.

@L4Ph L4Ph closed this as completed Nov 24, 2022
@krisfail
Copy link
Collaborator

私の不手際でご迷惑をおかけしました。
I apologize for any inconvenience caused by my carelessness.

@ClashSAN
Copy link
Collaborator

@yuuki76
No worries, we all try to help each other. :)
If you will be too busy, it's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants