From 73391dd7d4f8cf772c2fccf3bfb216e5ee238b43 Mon Sep 17 00:00:00 2001 From: vibes-863 Date: Thu, 14 Mar 2024 23:38:14 +0800 Subject: [PATCH 1/5] Delete DukeTest.java --- src/test/java/seedu/duke/DukeTest.java | 12 ------------ 1 file changed, 12 deletions(-) delete mode 100644 src/test/java/seedu/duke/DukeTest.java diff --git a/src/test/java/seedu/duke/DukeTest.java b/src/test/java/seedu/duke/DukeTest.java deleted file mode 100644 index 2dda5fd651..0000000000 --- a/src/test/java/seedu/duke/DukeTest.java +++ /dev/null @@ -1,12 +0,0 @@ -package seedu.duke; - -import static org.junit.jupiter.api.Assertions.assertTrue; - -import org.junit.jupiter.api.Test; - -class DukeTest { - @Test - public void sampleTest() { - assertTrue(true); - } -} From 707f7894eb3da7907fef77257d1b5956121c7e9f Mon Sep 17 00:00:00 2001 From: vibes-863 Date: Thu, 14 Mar 2024 23:38:51 +0800 Subject: [PATCH 2/5] Create JUnit test class - TransactionListTest.java --- src/test/java/financemanager/TransactionListTest.java | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 src/test/java/financemanager/TransactionListTest.java diff --git a/src/test/java/financemanager/TransactionListTest.java b/src/test/java/financemanager/TransactionListTest.java new file mode 100644 index 0000000000..e7643f2a55 --- /dev/null +++ b/src/test/java/financemanager/TransactionListTest.java @@ -0,0 +1,5 @@ +package financemanager; + +public class TransactionListTest { + +} From ef40daa59351274a9a25f0eebb68e5e439a69a51 Mon Sep 17 00:00:00 2001 From: vibes-863 Date: Fri, 15 Mar 2024 00:01:43 +0800 Subject: [PATCH 3/5] Update addTransaction to package-private --- src/main/java/financemanager/TransactionList.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/financemanager/TransactionList.java b/src/main/java/financemanager/TransactionList.java index 82ed096a0b..be01077b98 100644 --- a/src/main/java/financemanager/TransactionList.java +++ b/src/main/java/financemanager/TransactionList.java @@ -41,7 +41,7 @@ public void removeTransaction(String input){ } } - private void addTransaction(Transaction t) { + void addTransaction(Transaction t) { transactions.add(t); } From 91704ccaf4d184cb764ab4b1f3c22ed9883c46fe Mon Sep 17 00:00:00 2001 From: vibes-863 Date: Fri, 15 Mar 2024 00:02:28 +0800 Subject: [PATCH 4/5] Add removeTransaction_removesCorrectTransaction test case --- .../financemanager/TransactionListTest.java | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/src/test/java/financemanager/TransactionListTest.java b/src/test/java/financemanager/TransactionListTest.java index e7643f2a55..49ab699db6 100644 --- a/src/test/java/financemanager/TransactionListTest.java +++ b/src/test/java/financemanager/TransactionListTest.java @@ -1,5 +1,31 @@ package financemanager; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.BeforeEach; +import transactions.Transaction; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; + public class TransactionListTest { + + private TransactionList transactionList; + + @BeforeEach + public void setUp() { + transactionList = new TransactionList(); + } + @Test + public void removeTransaction_removesCorrectTransaction() { + Transaction testTransaction1 = new Transaction("Test1", 100,"Category1", "14-03-2024"); + Transaction testTransaction2 = new Transaction("Test2", 200,"Category2", "16-03-2024"); + transactionList.addTransaction(testTransaction1); + transactionList.addTransaction(testTransaction2); + + transactionList.removeTransaction("delete 1"); + + assertEquals(1, transactionList.getTransactions().size()); + assertEquals(testTransaction2, transactionList.getTransactions().get(0)); + } } From 325180dbb671de51e89c395dbe4514aba7b7e6b9 Mon Sep 17 00:00:00 2001 From: vibes-863 Date: Fri, 15 Mar 2024 00:05:30 +0800 Subject: [PATCH 5/5] Add removeTransaction IndexOutOfBounds test case --- .../java/financemanager/TransactionListTest.java | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/test/java/financemanager/TransactionListTest.java b/src/test/java/financemanager/TransactionListTest.java index 49ab699db6..6a3bcb75f3 100644 --- a/src/test/java/financemanager/TransactionListTest.java +++ b/src/test/java/financemanager/TransactionListTest.java @@ -15,11 +15,11 @@ public class TransactionListTest { public void setUp() { transactionList = new TransactionList(); } - + @Test public void removeTransaction_removesCorrectTransaction() { - Transaction testTransaction1 = new Transaction("Test1", 100,"Category1", "14-03-2024"); - Transaction testTransaction2 = new Transaction("Test2", 200,"Category2", "16-03-2024"); + Transaction testTransaction1 = new Transaction("Test1", 100, "Category1", "14-03-2024"); + Transaction testTransaction2 = new Transaction("Test2", 200, "Category2", "16-03-2024"); transactionList.addTransaction(testTransaction1); transactionList.addTransaction(testTransaction2); @@ -28,4 +28,12 @@ public void removeTransaction_removesCorrectTransaction() { assertEquals(1, transactionList.getTransactions().size()); assertEquals(testTransaction2, transactionList.getTransactions().get(0)); } + + @Test + public void removeTransaction_withInvalidIndex_throwsIndexOutOfBoundsException() { + Transaction testTransaction = new Transaction("Test", 200, "Personal", "14-03-2024"); + transactionList.addTransaction(testTransaction); + + assertThrows(IndexOutOfBoundsException.class, () -> transactionList.removeTransaction("delete 2")); + } }