Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for docker #195

Open
wants to merge 5 commits into
base: master
from

Conversation

@Edelstadt
Copy link

Edelstadt commented May 11, 2019

An example of how it could look Docker.
Up - docker-compose up -d --force-recreate
Start server - docker exec -it aardwolf_app_1 /src/aardwolf/aardwolf-server

Just example ...

Edelstadt and others added 4 commits May 11, 2019
@BanjoFox BanjoFox requested review from asonix and KD0BPV May 11, 2019
@BanjoFox

This comment has been minimized.

Copy link
Collaborator

BanjoFox commented May 11, 2019

Awesome!

I think that having Docker available to folks may help move things along more fluidly :)

RUN apt-get update && apt-get install -y \
gettext

RUN cargo build -Z unstable-options --out-dir /src/aardwolf --bin setup

This comment has been minimized.

Copy link
@asonix

asonix May 11, 2019

Collaborator

what is --out-dir doing here? are we dumping our binaries into the src/aardwolf folder of the project?

I realize it's not a huge deal since this is all containerized but it still seems like a weird place for it

This comment has been minimized.

Copy link
@asonix

asonix May 12, 2019

Collaborator

I'm gonna go ahead and also request that you make the change Banjo suggested

@asonix
asonix approved these changes May 11, 2019
@BanjoFox

This comment has been minimized.

Copy link
Collaborator

BanjoFox commented May 11, 2019


RUN cargo build -Z unstable-options --out-dir /src/aardwolf --bin setup

RUN cargo build -Z unstable-options --out-dir /src/aardwolf --bin aardwolf-server --features rocket --verbose

This comment has been minimized.

Copy link
@asonix

asonix May 12, 2019

Collaborator

We've deleted rocket in master, now. No features need to be provided to properly build the server, as there's a default now (actix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.