Return a result even when validation fails? #168

Closed
AaronLasseigne opened this Issue Apr 9, 2014 · 3 comments

Comments

Projects
None yet
3 participants
@AaronLasseigne
Owner

AaronLasseigne commented Apr 9, 2014

In #159 we were given a valid reason for passing back a result in all cases. We do not need the result to be nil in order to determine success because we already have valid?. Does it make sense to change this behavior?

I've marked this as 2.0.0 because it would be a breaking change to the interface.

@AaronLasseigne AaronLasseigne added this to the v2.0.0 milestone Apr 9, 2014

@egadstar

This comment has been minimized.

Show comment
Hide comment
@egadstar

egadstar Apr 17, 2014

Is there an eta when this might implemented?

Is there an eta when this might implemented?

@AaronLasseigne

This comment has been minimized.

Show comment
Hide comment
@AaronLasseigne

AaronLasseigne Apr 17, 2014

Owner

There's not an explicit date. We're working on a 1.2.0 release currently and as I mention this is 2.0.0 territory. Is this something that's causing issues for you?

Owner

AaronLasseigne commented Apr 17, 2014

There's not an explicit date. We're working on a 1.2.0 release currently and as I mention this is 2.0.0 territory. Is this something that's causing issues for you?

@egadstar

This comment has been minimized.

Show comment
Hide comment
@egadstar

egadstar Apr 17, 2014

Yea, I've needed to code around a few use cases(i.e. edit/creates that error) and change some requests to be ajax, so I have more control of the page when the outcome result is nil.

Yea, I've needed to code around a few use cases(i.e. edit/creates that error) and change some requests to be ajax, so I have more control of the page when the outcome result is nil.

@tfausak tfausak self-assigned this Aug 14, 2014

tfausak added a commit that referenced this issue Aug 15, 2014

Merge pull request #214 from orgsync/gh-168
Return results from invalid outcomes

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment