Rename model filter to object filter? #264

Closed
tfausak opened this Issue Mar 12, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@tfausak
Collaborator

tfausak commented Mar 12, 2015

The model filter doesn't really define a model. It defines an object. More specifically, it defines an instance of a class. For instance, if you want a Proc input, you have to do this:

model :proc

That doesn't really make sense to me. I think this would be better:

object :proc

I think we ended up with model because we usually use this filter for ActiveModel objects. But it's designed to work with anything. I think we should change the name to reflect that.

@tfausak tfausak added the question label Mar 12, 2015

@AaronLasseigne

This comment has been minimized.

Show comment
Hide comment
@AaronLasseigne

AaronLasseigne Mar 12, 2015

Owner
> Class.ancestors
=> [Class, Module, Object, Kernel, BasicObject]

It also seems to more clearly indicate the fact that it can be used for modules.

Owner

AaronLasseigne commented Mar 12, 2015

> Class.ancestors
=> [Class, Module, Object, Kernel, BasicObject]

It also seems to more clearly indicate the fact that it can be used for modules.

@AaronLasseigne

This comment has been minimized.

Show comment
Hide comment
@AaronLasseigne

AaronLasseigne Mar 12, 2015

Owner

I think this is a good change.

Owner

AaronLasseigne commented Mar 12, 2015

I think this is a good change.

tfausak added a commit that referenced this issue Mar 16, 2015

@tfausak tfausak self-assigned this Mar 16, 2015

@tfausak tfausak added this to the v2.0.0 milestone Mar 16, 2015

tfausak added a commit that referenced this issue Mar 17, 2015

Merge branch 'v2.0.0' into gh-264
Conflicts:
	lib/active_interaction.rb

@tfausak tfausak closed this Mar 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment