New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check other kinds of class equality #180

Merged
merged 7 commits into from May 2, 2014

Conversation

Projects
None yet
1 participant
@tfausak
Collaborator

tfausak commented May 2, 2014

Fixes #179.

@tfausak tfausak added the bug label May 2, 2014

@tfausak tfausak self-assigned this May 2, 2014

@tfausak

This comment has been minimized.

Show comment
Hide comment
@tfausak

tfausak May 2, 2014

Collaborator

I'm indifferent about checking #instance_of?. On the one hand, it's easy to check. On the other,

Why would you overwrite instance_of? and not is_a??

Collaborator

tfausak commented May 2, 2014

I'm indifferent about checking #instance_of?. On the one hand, it's easy to check. On the other,

Why would you overwrite instance_of? and not is_a??

@tfausak

This comment has been minimized.

Show comment
Hide comment
@tfausak

tfausak May 2, 2014

Collaborator

As if there weren't enough ways to do this, we could also use self.< on the value's class.

value.class < @klass
Collaborator

tfausak commented May 2, 2014

As if there weren't enough ways to do this, we could also use self.< on the value's class.

value.class < @klass

@tfausak tfausak merged commit cac02d3 into master May 2, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@tfausak tfausak deleted the issue-179 branch May 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment