Don't eagerly evaluate proc defaults #271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #269.
This pull request makes it so that defaults don't get eagerly evaluated if they're procs. Take this interaction for example:
Simply by defining this class,
"default"
will be output the standard out. That's a little surprising.We eagerly evaluate defaults to make sure you didn't give us something that would never work. Since procs can change every time they are called, it doesn't make sense to eagerly evaluate them for this purpose.