Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Set multiple tags #28
You are correct. I missed the fact that these field names don't have to be unique. This is going to be an issue if you have an existing file with multiple tags too.
Not sure how to fix it without breaking the API though. I'll look into it.
Thanks a lot for the feedback, it means a lot!
What would you think of something like this? This would leave the original API untouched. It's not as clean though. Given my (probably) small user-based I might be better off breaking the API:
This was referenced
Jul 11, 2016
Have a look in the tests to see the usage, especially "AddMultipleVorbisFields" in the write tests.
I would personally go for breaking the API, since adjusting the existing code isn't really that hard (just add .First) and this library (I think) has a small (but non-zero, I'm happy to hear) user-base. Additionally multiple tags is "encouraged" by the VORBIS spec, so making it the default would make sense.
Please let me know what you think, if you have the time.
Thanks for the quick implementations.
Both ways looks great for me, just having this feature implemented would be nice. And yes, my request is because Vorbis recommend to use multiple ARTIST tags if there are really multiple artists, and both Windows and Linux support it very well.
Although, from my coding style preference, the one who "breaks the API" also breaks the most common C# coding style.
There's also another complex way, allowing the use to set both
By changing all code to reference them as
Do you mean it breaks a common C# coding style because it doesn't allow you to do this anymore?
I see what you mean.
I guess I could put a safeguard in there if it's not a supported type, but that would defer what are now compile-time errors to be run-time errors.
Would it make more sense if it was like this:
I'll have to sleep about it :-)
I merged to master, planning to make this version 2.0 and just release it as non-beta to nuget.
Again, thanks for your interest. It's really more fun if other people are using your stuff :-)
Out of curiousity, can you share any info on what you're doing with the library?