Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save() doesn't create a file with the original permissions #35

Closed
krultan opened this issue Oct 18, 2017 · 2 comments

Comments

@krultan
Copy link

commented Oct 18, 2017

In Save(), the file is created in a temporary directory and then moved to the right place. In my case, the original file looses its 'Everyone read' permissions.

@AaronLenoir

This comment has been minimized.

Copy link
Owner

commented Oct 18, 2017

Thanks for taking the time to create this issue.

That's a problem indeed, I'll look into it.

AaronLenoir added a commit that referenced this issue Oct 19, 2017

Merge pull request #36 from AaronLenoir/issue-35
Fixes Issue #35: Save() doesn't create a file with the original permissions
@AaronLenoir

This comment has been minimized.

Copy link
Owner

commented Oct 19, 2017

Hi krultan, I have release version 3.0.3 that fixes this. It should be available on NuGet by now.

I'm now using File.Copy to overwrite the original with the temp file, and then deleting the temp file. According to the File.Copy documentation: "The attributes of the original file are retained in the copied file. "

I have a test case as well that reproduced your issue, which 3.0.3 resolved.

Please re-open or create a new issue if you still have problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.