New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CI to trust #122

Merged
merged 3 commits into from May 6, 2017

Conversation

2 participants
@alexeyzab
Contributor

alexeyzab commented May 5, 2017

These changes configure the trust template to use the correct
credentials and project name.

This is an initial pass at setting up the new CI. If there are any
addition tweaks that need to be done here, let me know.

Thanks!

#120

@Aaronepower

This comment has been minimized.

Show comment
Hide comment
@Aaronepower

Aaronepower May 5, 2017

Owner

Thank you for the PR! The nightly channels seem to be consistently failing to build. Could you have a look at why?

Owner

Aaronepower commented May 5, 2017

Thank you for the PR! The nightly channels seem to be consistently failing to build. Could you have a look at why?

@alexeyzab

This comment has been minimized.

Show comment
Hide comment
@alexeyzab

alexeyzab May 5, 2017

Contributor

@Aaronepower Sure! It seems to be a recent issue with rustup: rust-lang-nursery/rustup.rs#1092. I'll keep checking till it gets resolved.

Contributor

alexeyzab commented May 5, 2017

@Aaronepower Sure! It seems to be a recent issue with rustup: rust-lang-nursery/rustup.rs#1092. I'll keep checking till it gets resolved.

@alexeyzab

This comment has been minimized.

Show comment
Hide comment
@alexeyzab

alexeyzab May 5, 2017

Contributor

I've enabled allow_failures for nightly builds on travis-ci. I keep trying to get the same option to work for appveyor, but I think I am messing up the config file somehow. Sorry about that.

EDIT: if the CI tests pass, I'll do a rebase and squash all these commits to clean it up a bit.

Contributor

alexeyzab commented May 5, 2017

I've enabled allow_failures for nightly builds on travis-ci. I keep trying to get the same option to work for appveyor, but I think I am messing up the config file somehow. Sorry about that.

EDIT: if the CI tests pass, I'll do a rebase and squash all these commits to clean it up a bit.

Move CI to trust
These changes configure the trust template to use the correct
credentials and project name. The rest was left as is.

There seems to be an issue with rustup at the moment
rust-lang-nursery/rustup.rs#1092. As suggested in
rust-lang-nursery/rustup.rs#1092 (comment)
I've enabled the `allow_failures` feature for nightly builds.
@Aaronepower

This comment has been minimized.

Show comment
Hide comment
@Aaronepower

Aaronepower May 5, 2017

Owner

This looks great! Could you also add a beta channel, so we can know ahead of time if tokei has a soundness bug or anything similar before it hits stable.

Owner

Aaronepower commented May 5, 2017

This looks great! Could you also add a beta channel, so we can know ahead of time if tokei has a soundness bug or anything similar before it hits stable.

@alexeyzab

This comment has been minimized.

Show comment
Hide comment
@alexeyzab

alexeyzab May 5, 2017

Contributor

Done. Let me know if there is anything else I can help with here.

Contributor

alexeyzab commented May 5, 2017

Done. Let me know if there is anything else I can help with here.

@Aaronepower

This comment has been minimized.

Show comment
Hide comment
@Aaronepower

Aaronepower May 5, 2017

Owner

@alexeyzab Sorry, we want betas to give us an error on failure. I'm also not seeing any beta builds in either travis or appveyor?

Owner

Aaronepower commented May 5, 2017

@alexeyzab Sorry, we want betas to give us an error on failure. I'm also not seeing any beta builds in either travis or appveyor?

@alexeyzab

This comment has been minimized.

Show comment
Hide comment
@alexeyzab

alexeyzab May 5, 2017

Contributor

@Aaronepower My bad, I'll look into that.

Contributor

alexeyzab commented May 5, 2017

@Aaronepower My bad, I'll look into that.

@alexeyzab

This comment has been minimized.

Show comment
Hide comment
@alexeyzab

alexeyzab May 5, 2017

Contributor

I've added beta channels back in for both travis and appveyor. I took all the targets from the old .travis.yml.

Contributor

alexeyzab commented May 5, 2017

I've added beta channels back in for both travis and appveyor. I took all the targets from the old .travis.yml.

@Aaronepower Aaronepower merged commit d6910d1 into Aaronepower:master May 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Aaronepower

This comment has been minimized.

Show comment
Hide comment
@Aaronepower

Aaronepower May 6, 2017

Owner

Thank you!

Owner

Aaronepower commented May 6, 2017

Thank you!

@alexeyzab alexeyzab deleted the alexeyzab:move-ci-to-trust branch May 6, 2017

@Aaronepower Aaronepower referenced this pull request May 8, 2017

Closed

Move CI to trust #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment