New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .psl, .e, .ckt, .sv, .svh, .vg, .vh, .irunargs, .xrunargs #152

Merged
merged 1 commit into from Nov 30, 2017

Conversation

2 participants
@kaushalmodi
Contributor

kaushalmodi commented Oct 10, 2017

File formats:

  • Property Specification Language (.psl)
  • Specman E (.e)
  • SPICE netlist (.ckt)
  • SystemVerilog (.sv, .svh)
  • Verilog (.vg, .vh)
  • Verilog Run Argument files (.irunargs, .xrunargs)

Note that .v files are the default for Verilog files, but at the moment that clashes with Coq files. How can that be resolved?

@kaushalmodi kaushalmodi changed the title from Add support for .psl, .e, .ckt, .sv, .svh, .vg, .irunargs, .xrunargs to Add support for .psl, .e, .ckt, .sv, .svh, .vg, .vh, .irunargs, .xrunargs Oct 10, 2017

Add support for .psl, .e, .ckt, .sv/svh, .vg/vh, .irunargs/xrunargs
File formats:

- Property Specification Language (.psl)
- Specman E (.e)
- SPICE netlist (.ckt)
- SystemVerilog (.sv, .svh)
- Verilog (.vg, .vh)
  - Note that .v files are **the default** for Verilog files, but at the moment
    that clashes with Coq files. How can that be resolved?
- Verilog Run Argument files (.irunargs, .xrunargs)
@Aaronepower

This comment has been minimized.

Show comment
Hide comment
@Aaronepower

Aaronepower Oct 10, 2017

Owner

Unfortunately at the moment there is no way for tokei to handle file extension conflicts. Once I manage to figure out a solution for #67 conflicts can be resolved with that.

Could you add test files for these extensions as well?

Owner

Aaronepower commented Oct 10, 2017

Unfortunately at the moment there is no way for tokei to handle file extension conflicts. Once I manage to figure out a solution for #67 conflicts can be resolved with that.

Could you add test files for these extensions as well?

@Aaronepower

This comment has been minimized.

Show comment
Hide comment
@Aaronepower

Aaronepower Nov 30, 2017

Owner

Thank you for this PR!

Owner

Aaronepower commented Nov 30, 2017

Thank you for this PR!

@Aaronepower Aaronepower merged commit 043a780 into Aaronepower:master Nov 30, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kaushalmodi

This comment has been minimized.

Show comment
Hide comment
@kaushalmodi

kaushalmodi Nov 30, 2017

Contributor

I had to write tests for this PR but never got to that.

Contributor

kaushalmodi commented Nov 30, 2017

I had to write tests for this PR but never got to that.

@kaushalmodi kaushalmodi deleted the kaushalmodi:add-support-for-asic-design-dv-files branch Feb 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment