New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GLSL support #72

Merged
merged 5 commits into from Oct 15, 2016

Conversation

2 participants
@svenstaro
Contributor

svenstaro commented Oct 15, 2016

I followed the official extensions for this.

@Aaronepower

This comment has been minimized.

Show comment
Hide comment
@Aaronepower

Aaronepower Oct 15, 2016

Owner

@svenstaro Tjanks for the pull request! There are just some minor changes that need to be made before I can merge this in.

Remove GLSL from the CHANGELOG that only gets updated when there is a new Cargo version. I plan on releasing one soon and will include it with that release.

The enum name should be changed from GLSL to Glsl as that is the preferred style in rust code. The string version should remain the same. Thanks!

Owner

Aaronepower commented Oct 15, 2016

@svenstaro Tjanks for the pull request! There are just some minor changes that need to be made before I can merge this in.

Remove GLSL from the CHANGELOG that only gets updated when there is a new Cargo version. I plan on releasing one soon and will include it with that release.

The enum name should be changed from GLSL to Glsl as that is the preferred style in rust code. The string version should remain the same. Thanks!

@svenstaro

This comment has been minimized.

Show comment
Hide comment
@svenstaro

svenstaro Oct 15, 2016

Contributor

@Aaronepower addressed!

Contributor

svenstaro commented Oct 15, 2016

@Aaronepower addressed!

@Aaronepower Aaronepower merged commit d981333 into Aaronepower:master Oct 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment