Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask: Add people section #14

Open
Abdur-rahmaanJ opened this issue Jul 15, 2019 · 18 comments

Comments

@Abdur-rahmaanJ
Copy link
Owner

commented Jul 15, 2019

add another view -> people, see products or appointments and do the same | any help needed ask!

People need the following:

  • Name
  • Surname
  • Age
  • Info

Others as needed

You are expected to add an icon in nav.

@ParinitaChowdhry

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

i want to contribute. is it okay if i can do this by 27th July?

@Lutrome

This comment has been minimized.

Copy link

commented Jul 17, 2019

I'd like to contribute as well.

@Abdur-rahmaanJ

This comment has been minimized.

Copy link
Owner Author

commented Jul 17, 2019

@ParinitaChowdhry ok np, for the people section, just we did some update and ... just see how the other sections were implemented, we are really sorry for not providing proper docs.

@Lutrome are you willing to start making the point of sales section? Which will sell products specified in the model?

@Lutrome

This comment has been minimized.

Copy link

commented Jul 17, 2019

Yes, I’ll start the point of sales section.

@Abdur-rahmaanJ

This comment has been minimized.

Copy link
Owner Author

commented Jul 18, 2019

@Lutrome can you see issue #24 and comment there, so that github will allow me assigning this issue to you!

@ParinitaChowdhry

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

@Abdur-rahmaanJ : i think we do not need to store age in people model as it is calculated field, shall I remove it?

@blips5

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2019

Hi @ParinitaChowdhry
Can i ask a couple questions.
Should age be removed or swapped for another value i.e.
Do you think it should be a date? so age can be calculated. keeping peoples age correct and up to date.
or
have you got any other ideas of storing age?

@Abdur-rahmaanJ

This comment has been minimized.

Copy link
Owner Author

commented Jul 29, 2019

@ParinitaChowdhry or it can be added in models just for records i.e. calculated before inserting in db. might be useful to skip client side work. but definitely not needed to ask user to input age.

@ParinitaChowdhry

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

Hi @Abdur-rahmaanJ :
I see there is a people model. We store : name, age, birthday, about and social_media.
I propose not storing age as birthday is being stored. we may calculate age if required.
I will be adding validation for unique name. Do u have a min age to be validated? any suggestions for social media input validation?
Thanks.

@Abdur-rahmaanJ

This comment has been minimized.

Copy link
Owner Author

commented Jul 30, 2019

@ParinitaChowdhry no worry for social media validation. Calculating age might be a pain, better store it. Yes, unique name is a must but i think unique id better as name can be same.

@Abdur-rahmaanJ

This comment has been minimized.

Copy link
Owner Author

commented Aug 1, 2019

@ParinitaChowdhry just updated project for cleaner templates, just folderised everything, please have a look

@ParinitaChowdhry

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

@Abdur-rahmaanJ : i committed my changes n merged them. I am not sure why I do not see them when i access the project via github. Please help to see if everything ok.

@blips5

This comment has been minimized.

Copy link
Collaborator

commented Aug 3, 2019

@ParinitaChowdhry did u issue a PR.

@blips5

This comment has been minimized.

Copy link
Collaborator

commented Aug 3, 2019

@ParinitaChowdhry Just seen your PR. it has been closed, did you delete your branch before the pull request had been merged. 😺

@ParinitaChowdhry

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

@blips5: i re-opened the PR.

@Abdur-rahmaanJ

This comment has been minimized.

Copy link
Owner Author

commented Aug 4, 2019

shopyo_people

@ParinitaChowdhry Check age, bit weird ^^_

Also, can you add name, mail and address section and instead of social media add facebook, twitter and linkedin?

@ParinitaChowdhry

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

@Abdur-rahmaanJ : to clarify, you want to add separate sections each for name, mail and address and facebook, twitter and linkedin? or change details in people section and instead of social media, display facebook, twitter and linkedin?

@Abdur-rahmaanJ

This comment has been minimized.

Copy link
Owner Author

commented Aug 12, 2019

@ParinitaChowdhry modify people replace social media by fb linkedin etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.