diff --git a/README.md b/README.md index 21f0253..097da59 100644 --- a/README.md +++ b/README.md @@ -134,14 +134,7 @@ Using the following template, create a `Dockerfile` in a module for which you wa ```dockerfile -# leave it empty, the value is passed from outside -ARG DOCKER_BASE_IMAGE_PREFIX - -# specify your desired base image -ARG MY_BASE_IMAGE=my_base_docker_image_coordinates - -# all pulling images MUST be prefixed like this -FROM "$DOCKER_BASE_IMAGE_PREFIX""$MY_BASE_IMAGE" +FROM base_docker_image_coordinates # legal stuff LABEL \ @@ -161,7 +154,6 @@ LABEL \ # ARG PROJECT_BUILD_FINAL_NAME # The rest of your Dockerfile here -??? ``` @@ -179,8 +171,8 @@ In the corresponding `pom.xml`, specify the Docker image name and enable the doc - com.spotify - dockerfile-maven-plugin + io.fabric8 + docker-maven-plugin false @@ -206,7 +198,7 @@ Specify `dockerfile.repositoryUrl` property accordingly and execute Maven `deplo The example command below with create an image and push into the AbsaOSS space on the Docker Hub. ```shell -mvn install -Ddocker -Ddockerfile.repositoryUrl=docker.io/absaoss +mvn deploy -Ddocker -Ddockerfile.repositoryUrl=docker.io/absaoss ``` ##### Tweaking image names and tags diff --git a/pom.xml b/pom.xml index 3d30e89..fce8159 100644 --- a/pom.xml +++ b/pom.xml @@ -91,9 +91,6 @@ ${dockerfile.repositoryPrefix}${dockerfile.imageName}${dockerfile.repositorySuffix} - - - 0.8.8 @@ -271,45 +268,49 @@ - com.spotify - dockerfile-maven-plugin + io.fabric8 + docker-maven-plugin - tag-version + docker-build + install build - push - - ${dockerfile.versionTagName} - - tag-latest + docker-push + deploy - tag push - - ${dockerfile.latestTagName} - true - - ${dockerfile.repository} - - ${dockerfile.baseImagePrefix} - ${project.name} - ${project.groupId} - ${project.artifactId} - ${project.version} - ${project.basedir} - ${project.build.directory} - ${project.build.finalName} - - true + + + ${dockerfile.repository} + + ${project.basedir} + + ${dockerfile.versionTagName} + ${dockerfile.latestTagName} + + false + + ${project.name} + ${project.groupId} + ${project.artifactId} + ${project.version} + ${project.basedir} + ${project.build.directory} + ${project.build.finalName} + + + + + @@ -400,9 +401,9 @@ 1.6.8 - com.spotify - dockerfile-maven-plugin - 1.4.13 + io.fabric8 + docker-maven-plugin + 0.40.3