New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spline UI: search is not working #166
Comments
What is mysearchstring?
|
Thank you @algattik for your help isolating this! @wajda is there any way we can change Spline to not use the PCRE search expressions to work around the current limitation in the MongoDB API within Azure Cosmos DB? If there is any way we can change Spline (in a fork) to test the workaround, then we will be glad to try that locally. Just let us know what you might suggest. |
I confirm that by changing in BaselineLineageDAO:
to
The search works against Cosmos DB. @wajda would you consider any of:
If you agree to any of those, I'm happy to submit a PR. |
@algattik Thank you for your contribution. Absolutely, please feel free to submit a PR. We'll be glad to merge it after review. |
@AbsaOSS/spline |
…than using Pattern.quote(), for Cosmos DB compatibility. Fixes AbsaOSS#166.
Merged. |
* Escape special characters one by one when searching Mongo DB, rather than using Pattern.quote(), for Cosmos DB compatibility. Fixes #166. * Added test for quoteSafely * Moved constant to companion object * Fixed support for \ and $ chars in search
I am running the UI app JAR locally and while the main functions seem to work correctly, the search function seems to be broken. In that typing in a search string is not returning anything (i.e. the left pane gets blank). I debugged that the REST API call (sample below) is returning a blank array [].
http://localhost:8080/rest/dataset/descriptors?q=mysearchstring&asAtTime=1553556446120&offset=0&size=20
There is no firewall or such - the UI is running local to the browser. From the UI output, there is no exception shown. The only variable is that I am using Azure Cosmos DB Mongo API but again on the server side there is no apparent issue. Is there any further logging I can turn on at the Java side to debug this issue further?
The text was updated successfully, but these errors were encountered: