New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible merge with libsdl-d #20

Closed
mihails-strasuns opened this Issue Dec 14, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@mihails-strasuns

mihails-strasuns commented Dec 14, 2014

I am currently working on SDL support for dub (originally started by Jonathan Marler) and use effectively fork of your project (https://github.com/Dicebot/libsdl-d). I don't want upstream communication to be a bottleneck for now and remember that some changes I did you had a very strong opinion about so won't bother with trying to submit it as a PR right now. Still you should know about it in case you want to pick some fixes early.

@Abscissa

This comment has been minimized.

Show comment
Hide comment
@Abscissa

Abscissa Jul 29, 2015

Owner

Thanks. I probably will incorporate some of your changes. I'm readying a new release right now, so most of what I merge will probably be in the following release after that.

I do remember (IIRC) we had strongly differing opinions on wrapping unittests in project-specific version blocks (FWIW, I do think D/dub can and should be enhanced to support both our preferences of being able to easily run tests for all dependencies and easily run tests for just the base project. It's a shame the toolchain can't handle both approaches right now for a single codebase). But was there something else too? That's the only one I remember.

Owner

Abscissa commented Jul 29, 2015

Thanks. I probably will incorporate some of your changes. I'm readying a new release right now, so most of what I merge will probably be in the following release after that.

I do remember (IIRC) we had strongly differing opinions on wrapping unittests in project-specific version blocks (FWIW, I do think D/dub can and should be enhanced to support both our preferences of being able to easily run tests for all dependencies and easily run tests for just the base project. It's a shame the toolchain can't handle both approaches right now for a single codebase). But was there something else too? That's the only one I remember.

@mihails-strasuns

This comment has been minimized.

Show comment
Hide comment
@mihails-strasuns

mihails-strasuns Jul 29, 2015

I remember making at least one big-fix (https://github.com/Dicebot/libsdl-d/commit/e565f302a60585cd25a8443a0439c8aec18f2515 + https://github.com/Dicebot/libsdl-d/commit/c6dc72284c93a8e42ec0d9db6803e226358d5022) - that is probably something that should be uncontroversial :)

Yeah unittest thing was the one we argued about but I also got impression that you prefer flat hierarchy with version blocks separating different compilation models while I find it very hard to figure out and prefer strictly separated dub configurations (or makefile targets) - weren't sure you will be happy to make such changes.

Anyway, I don't really need this project anymore so ping me once you have cherry-picked everything of use - will delete it to not confuse people doing github search.

mihails-strasuns commented Jul 29, 2015

I remember making at least one big-fix (https://github.com/Dicebot/libsdl-d/commit/e565f302a60585cd25a8443a0439c8aec18f2515 + https://github.com/Dicebot/libsdl-d/commit/c6dc72284c93a8e42ec0d9db6803e226358d5022) - that is probably something that should be uncontroversial :)

Yeah unittest thing was the one we argued about but I also got impression that you prefer flat hierarchy with version blocks separating different compilation models while I find it very hard to figure out and prefer strictly separated dub configurations (or makefile targets) - weren't sure you will be happy to make such changes.

Anyway, I don't really need this project anymore so ping me once you have cherry-picked everything of use - will delete it to not confuse people doing github search.

@Abscissa

This comment has been minimized.

Show comment
Hide comment
@Abscissa

Abscissa Jul 29, 2015

Owner

I remember making at least one big-fix (Dicebot/libsdl-d@e565f30 + Dicebot/libsdl-d@c6dc722) - that is probably something that should be uncontroversial :)

Yea, I grabbed that one last night ;) fb23833

but I also got impression that you prefer flat hierarchy with version blocks separating different compilation models while I find it very hard to figure out and prefer strictly separated dub configurations (or makefile targets) - weren't sure you will be happy to make such changes.

I think part of that was, at that point, I was uneasy about dub's subprojects feature and didn't really want to start diving into that. Plus I didn't really see much need.

But since then, I've had to get more familiar with dub's subprojects anyway (for a different project). And looking closer at your libsdl-d last night, I admit at first I was a little weirded out and confused by it, but it does seem to have some merit and cleanliness. I might end up adopting that after all.

Anyway, I don't really need this project anymore so ping me once you have cherry-picked everything of use - will delete it to not confuse people doing github search.

Understood, I will let you know.

Owner

Abscissa commented Jul 29, 2015

I remember making at least one big-fix (Dicebot/libsdl-d@e565f30 + Dicebot/libsdl-d@c6dc722) - that is probably something that should be uncontroversial :)

Yea, I grabbed that one last night ;) fb23833

but I also got impression that you prefer flat hierarchy with version blocks separating different compilation models while I find it very hard to figure out and prefer strictly separated dub configurations (or makefile targets) - weren't sure you will be happy to make such changes.

I think part of that was, at that point, I was uneasy about dub's subprojects feature and didn't really want to start diving into that. Plus I didn't really see much need.

But since then, I've had to get more familiar with dub's subprojects anyway (for a different project). And looking closer at your libsdl-d last night, I admit at first I was a little weirded out and confused by it, but it does seem to have some merit and cleanliness. I might end up adopting that after all.

Anyway, I don't really need this project anymore so ping me once you have cherry-picked everything of use - will delete it to not confuse people doing github search.

Understood, I will let you know.

@Abscissa Abscissa closed this Sep 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment