Wrong line count for Windows style line breaks #28

Closed
s-ludwig opened this Issue Jul 27, 2015 · 0 comments

Projects

None yet

1 participant

@s-ludwig
Contributor

From a quick skim over the lexer module, it looks like \r\n is correctly detected, but then after incrementing the line counter only the \r is consumed. This results in line numbers that are off by a factor of two on Windows.

@s-ludwig s-ludwig added a commit to s-ludwig/SDLang-D that referenced this issue Jul 27, 2015
@s-ludwig s-ludwig Add unit test for line counting behavior (issue #28). 611efde
@s-ludwig s-ludwig added a commit to s-ludwig/SDLang-D that referenced this issue Jul 27, 2015
@s-ludwig s-ludwig Fix line counting for Windows-style line endings. Fixes #28. 1d5174a
@s-ludwig s-ludwig added a commit to s-ludwig/SDLang-D that referenced this issue Jul 27, 2015
@s-ludwig s-ludwig Add unit test for line counting behavior (issue #28). 2445280
@s-ludwig s-ludwig added a commit to s-ludwig/SDLang-D that referenced this issue Jul 27, 2015
@s-ludwig s-ludwig Fix line counting for Windows-style line endings. Fixes #28. 6b79bbb
@s-ludwig s-ludwig added a commit to s-ludwig/SDLang-D that referenced this issue Jul 27, 2015
@s-ludwig s-ludwig Add unit test for line counting behavior (issue #28). bfb6f7c
@Abscissa Abscissa closed this in 820907c Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment