Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix line counter for Windows-style line endings. Fixes #28. #29
Not sure if using an
Also fixes the "unittest" configuration in package.json and fixes the line numbers reported by
BTW, unrelated to this fix, when running "dub test" (on Windows), I'm getting an access violation in
Hmm, I think if we just document
If you do that, and adjust the
Does the version identifiers changing from
Ouch. I'll take a look. Can you open a separate ticket for this?
Okay, I've update the PR with your suggestions. Sorry about the mismatched code style, I somehow got so used to it (after adjusting my own preferences a while ago), because virtually all D code looks like that nowadays, that I didn't even think that it could be different ;)
Yes, that's the fix, because the lower-case versions are the ones that are used in the D code. Looks like they are a relict of earlier versions?
Seems to be #16 - it crashes in the regression test for that issue. But it looks like it was simply never fixed in the first place, commit cc626fd just adds the regression test. And the
Oops, yes, that would be it.
The actual fix was in libInputVisitor, version 1.2. SDLang itself didn't need to be updated, it just needs to use the latest libInputVisitor...which...I seem to have forgotten to update package.json to require...(/facepalm)... I guess I should probably update