Add more examples #302
Merged
Add more examples #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
800d996
|
| Status: | 🚫 Build failed. |
CyberHoward
approved these changes
Jan 23, 2024
Contributor
CyberHoward
left a comment
CyberHoward
left a comment
There was a problem hiding this comment.
This is great! For the AsyncDaemon we can leave it as it is.
If we really need a good async implementation in the future we can create an AsyncTxHandler trait that's equivalent to the current TxHandler but is all async. But that's not worth doing at the moment.
CyberHoward
reviewed
Jan 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at adding more examples and doc examples for users to interact with.
Issue with async daemon
It's difficult to interact with the async daemon and contracts
--> For instance, the upload needs an Uploadable argument, but it's not possible to create one with the AsyncDaemon because it doesn't implement TxHandler.
Should we remove that example or change AsyncDaemon a little ?
I don't think it's worth the effort to be honest