-
Notifications
You must be signed in to change notification settings - Fork 28
Loosen trait bounds in cw-orch-core #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying cw-orchestrator with
|
| Latest commit: |
be82090
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d86b11d3.cw-orchestrator.pages.dev |
| Branch Preview URL: | https://nicolas-orc-104-trait-bounds.cw-orchestrator.pages.dev |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
| } | ||
|
|
||
| /// Helper methods for conditional uploading of a contract. | ||
| pub trait ConditionalUpload<Chain: CwEnv>: CwOrchUpload<Chain> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we loosen this bound as well? Could you search for all the uses of CwEnv in this library and replace them with their minimal requirements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I did yes ! And we can't loosen that bound because you need both QueryHandler and TxHandler to be able to use this trait !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emoved in the proc macros as well :)
CyberHoward
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing, is this a breaking change to core?
I'm not sure how to test that :/ |
It shouldn't be, but I'm not sure there were not changes in the main branch that were breaking |
This is important for you to keep track of. You can go through commits on main and see if any of them are PRs that you expect to be breaking and look into them. |
This Pr aims at loosening some trait bounds in cw-orch-core because theyr are un-necessary