Skip to content

Conversation

@Buckram123
Copy link
Contributor

Now panics on unimplemented only if access control is Some

@Buckram123 Buckram123 requested a review from Kayanski September 30, 2024 14:01
@Kayanski
Copy link
Contributor

LGTM, hope that doesn't create recursions!

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 30, 2024

Deploying cw-orchestrator with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3f22bb6
Status:⚡️  Build in progress...

View logs

@Kayanski Kayanski merged commit d5afc96 into main Oct 1, 2024
@Kayanski Kayanski deleted the buckram/fix-upload-with-access-unimplemented branch October 1, 2024 08:28
@codecov
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.9%. Comparing base (957cfb7) to head (3f22bb6).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/cw-orch-core/src/environment/tx_handler.rs 0.0% 8 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...ackages/cw-orch-core/src/environment/tx_handler.rs 18.1% <0.0%> (-1.0%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants