From f697f4215cdc4b98100c9e40aad871de97a96ef8 Mon Sep 17 00:00:00 2001 From: Cary Phillips Date: Thu, 24 Oct 2019 14:14:00 -0700 Subject: [PATCH] SonarCloud-inspired fixes - Added =delete copy constructors and assignment operators - Added =default destructors - check for &other==this in assignment operator Signed-off-by: Cary Phillips --- PyIlmBase/PyImath/PyImathUtil.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PyIlmBase/PyImath/PyImathUtil.h b/PyIlmBase/PyImath/PyImathUtil.h index 7a8eb6e7..b70ea742 100644 --- a/PyIlmBase/PyImath/PyImathUtil.h +++ b/PyIlmBase/PyImath/PyImathUtil.h @@ -66,7 +66,7 @@ class PyAcquireLock PYIMATH_EXPORT PyAcquireLock(); PYIMATH_EXPORT ~PyAcquireLock(); PYIMATH_EXPORT PyAcquireLock(const PyAcquireLock& other) = delete; - PYIMATH_EXPORT PyAcquireLock & operator = (PyAcquireLock& other) = delete; + PYIMATH_EXPORT const PyAcquireLock & operator = (PyAcquireLock& other) = delete; private: PyGILState_STATE _gstate; @@ -88,7 +88,7 @@ class PyReleaseLock PYIMATH_EXPORT PyReleaseLock(); PYIMATH_EXPORT ~PyReleaseLock(); PYIMATH_EXPORT PyReleaseLock(const PyReleaseLock& other) = delete; - PYIMATH_EXPORT PyReleaseLock & operator = (PyReleaseLock& other) = delete; + PYIMATH_EXPORT const PyReleaseLock & operator = (PyReleaseLock& other) = delete; private: PyThreadState *_save;