Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with non-ascii folders on Windows #406

Closed
sergeyvfx opened this issue Apr 26, 2016 · 3 comments · Fixed by #1363
Closed

Issues with non-ascii folders on Windows #406

sergeyvfx opened this issue Apr 26, 2016 · 3 comments · Fixed by #1363
Labels

Comments

@sergeyvfx
Copy link
Contributor

It is not possible to use configuration file which is located in a folder with non-ASCII characters on Windows. This is because simple char* is used to communicate filepath to a config file in Config::CreateFromFile().

In order to have full Unicode support it seems adding similar Config::CreateFromFile(wchar_t*) will be needed. Or at least will need to be done some ASCII->UTF conversion in the function itself.

In order to reproduce the issue it should be enough to simply call Config::CreateFromFile() with a filepath which has non-ascii characters, such as German umlauts for example.

@scoopxyz scoopxyz added the Minor label Jan 25, 2017
@hsdk123
Copy link

hsdk123 commented Oct 30, 2020

Hi, would it be possible to request an update to this? This has major impact on loading from non-english environments on Windows. The fix doesn't seem to be too difficult either.

@EvanAW
Copy link

EvanAW commented Mar 15, 2021

I am looking to get a pull request in for this hopefully later this week.

@Dithermaster
Copy link

BTW, the way we solved this host-side was to call GetShortPathName Windows API to convert paths to something that OCIOv1 can eat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants