Permalink
3 comments
on commit
sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Fix IlmBase 2.1 build breakages
(other minor changes are due to syncing with the analogous file in OIIO)
- Loading branch information
Showing
1 changed file
with
8 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17ce277There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t know what it fixes, but I can assure you this commit breaks again linux builds with latest ilmbase (2.1). I don’t know why ilmbase 2.1 libs are suffixed with '2_1', this does not makes any sense to me, but they do.
I have to say I’m really tired to have to hack around ilm libs each and every time we update our dependancies (I maintain the install_deps script for Blender)…
17ce277There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what this patch does is to look simply for libHalf.so, libIex.so, libImath.so, and libIlmThread.so, with no versions at all.
On most systems, the installation provides (as an example) libIex-2_1.so as well as libIex.so linking to it.
On your system, then, are you saying that you lack the libIex.so link, so you MUST have the one with the embedded version?
17ce277There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because our script also builds ilmbase/openexr (many distro are still stuck to old openEXR 1.6/ ilmbase 2.0.1 eg. for debian testing packages). And when we build those libs from 2.1 release code with CMake, it only generates those tagged '-2_1' names for ilmbase libs, no 'nice named' shortcuts…