always ignore chunkCount attribute unless it cannot be computed #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
meshula
approved these changes
May 25, 2020
There was a problem hiding this comment.
This looks good to me. I think the reason you are ignoring the bool rather than removing it, is it avoid a breaking API change. Could you add a note somewhere about the behavioral change and the deprecation, so that it can be highlighted in release notes, and so that we can remember to come back to this for the 3.0 API?
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Jun 11, 2020
…emySoftwareFoundation#738) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
cary-ilm
pushed a commit
that referenced
this pull request
Jun 12, 2020
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
smartin-13
pushed a commit
to smartin-13/openexr
that referenced
this pull request
Jul 23, 2020
…emySoftwareFoundation#738) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz> Signed-off-by: smartin-13 <61707536+smartin-13@users.noreply.github.com>
cary-ilm
pushed a commit
that referenced
this pull request
Aug 9, 2020
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
DominicJacksonBFX
pushed a commit
to boris-fx/mocha-openexr
that referenced
this pull request
Jun 22, 2022
…emySoftwareFoundation#738) Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Peter Hillman peterh@wetafx.co.nz