And HIP support for NanoVDB #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use host/device qualifiers when either __CUDACC__ or __HIP__ is defined * Add __hostdev__ to method definitions outside the class body. CUDA only needs them in the class body declaration, but HIP needs both. This makes using the NanoVDB headers as part of HIP C++ code work. It does not add support for HIP to the examples. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
kmuseth
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We are using HIP in Blender/Cycles for AMD GPU rendering, and some small changes are needed to make NanoVDB work.
https://github.com/ROCm-Developer-Tools/HIP
__CUDACC__or__HIP__is defined__hostdev__to method definitions outside the class body. CUDA only needs them in the class body declaration, but HIP needs both.This makes using the NanoVDB headers as part of HIP C++ code work. It does not add support for HIP to the examples. That would be a much bigger change and likely add much code duplication.