Add package_cache_async flag.
#1452
Conversation
|
Thanks @ttrently ! Can you follow the instructions at https://github.com/AcademySoftwareFoundation/rez/pull/1452/checks?check_run_id=11526898738 to fix the DCO check please? |
ttrently
force-pushed
the
package-cache-run-async
branch
from
cf3c234
to
f32b20a
Compare
|
A welcome addition. I want to add it should be implemented as a flag on For example: |
Adds a `package_cachy_async` flag which allows users to run caching synchronously (blocking) or asynchronously from the config. Signed-off-by: ttrently <41705925+ttrently@users.noreply.github.com>
Change _async to default True instead of False to mimic previous behavior. Signed-off-by: ttrently <41705925+ttrently@users.noreply.github.com>
Renamed `add_variants_async` to `add_variants` as this method can now run with an `_async` flag. Signed-off-by: ttrently <41705925+ttrently@users.noreply.github.com>
There was a problem hiding this comment.
Thanks @ttrently ! I think it could be a good idea to have a CLI flag, but I'm not sure what it should be named and to which commands it should apply. Any opinions?
| @@ -269,6 +269,9 @@ | |||
| # Enable package caching during a package build. | |||
| package_cache_during_build = False | |||
|
|
|||
| # Enable package caching to run asynchronously during a resolve. | |||
There was a problem hiding this comment.
I find this hard to read. How about "set to false to always cache package payloads synchronously"?
|
Also, the linter is complaining: https://github.com/AcademySoftwareFoundation/rez/actions/runs/4245498949/jobs/7387520293#step:5:1 |
Fixes #1379.
Adds a
package_cachy_asyncflag which allows users to run caching synchronously (blocking) or asynchronously from the config.This setting is set to
Trueby default in the rezconfig so that behavior should act as normal. Setting this to false will block the resolve until all packages have been cached successfully.