Skip to content

Conversation

@Knappek
Copy link
Contributor

@Knappek Knappek commented Sep 3, 2020

Description

  • lints and tests helm charts on pull requests
  • releases helm charts on github pages when merging to master

Closes #319

What to look out for

Dear reviewer, I want you to

  • gain knowledge - I think it's important for you to know about the change.
  • check that the code works on your machine.
  • suggest implementation-code design/structure/readability improvements.
  • suggest test-code design/structure/readability improvements.
  • suggest documentation improvements.
  • suggest language/writing improvements.
  • help to find bugs (described below!).

Process

The goal is to improve not only the code in this PR but also our skills! The "rules":

  • The review is considered "done" as soon as all reviewers have added their review, and all their comments have been addressed.
  • For knowledge-sharing reviews, each reviewer should "approve" the PR after studying its content.
  • After the approval, the merge is concluded by the developer.

Have fun!

@Knappek Knappek force-pushed the 319-test-and-publish-helm-chart branch from 31bea18 to a32c037 Compare September 3, 2020 19:29
@Knappek Knappek force-pushed the 319-test-and-publish-helm-chart branch 2 times, most recently from 0358913 to a7dde4c Compare September 7, 2020 10:16
@Knappek Knappek force-pushed the 319-test-and-publish-helm-chart branch from a7dde4c to 6d61417 Compare September 7, 2020 10:21
@Knappek Knappek marked this pull request as ready for review September 7, 2020 11:24
@Knappek Knappek requested a review from kevinbader September 7, 2020 11:26
@Knappek Knappek merged commit b2077a5 into master Sep 8, 2020
@Knappek Knappek deleted the 319-test-and-publish-helm-chart branch October 2, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Submit helm chart to Github Pages

4 participants