Skip to content

Conversation

@delan
Copy link

@delan delan commented Nov 13, 2025

No description provided.

delan and others added 7 commits November 13, 2025 20:42
Co-authored-by: Luke Warlow <lwarlow@igalia.com>
Co-authored-by: Luke Warlow <lwarlow@igalia.com>
Co-authored-by: Luke Warlow <lwarlow@igalia.com>
we were apparently misusing the term in some places to mean a subtree
that did not include the root (now called a child subtree).

<https://en.wikipedia.org/w/index.php?title=Glossary_of_graph_theory&oldid=1298088796#S>

Co-authored-by: Luke Warlow <lwarlow@igalia.com>
Co-authored-by: Luke Warlow <lwarlow@igalia.com>
Co-authored-by: Luke Warlow <lwarlow@igalia.com>
Co-authored-by: Luke Warlow <lwarlow@igalia.com>
@delan delan marked this pull request as ready for review November 13, 2025 13:09
@delan
Copy link
Author

delan commented Nov 13, 2025

as part of our work on adding accessibility support to Servo, we need a way to combine Servo’s accessibility tree with that of the embedding app, and ideally, combine accessibility trees for webviews and iframes within Servo (#604).

so far, we think the main concrete problem that needs to be solved when combining accessibility trees is ensuring that node ids are globally unique. we think we can do this by making a “meta-adapter” that rewrites tree updates and action requests from the various subtrees, replacing local node ids with globally unique ids.

the meta-adapter would know about the subtrees, where they meet, and which subtree each tree update came from. in exchange, it would expose an Adapter interface for each subtree, bound to that subtree (not yet implemented). internally it would own some concrete Adapter (currently winit in this patch).

this patch is a proof of concept, with only basic rewriting of node ids in tree updates. it does not rewrite action requests yet, nor does it correctly rewrite root node and focused node updates.

(cc @lukewarlow, @alice, @Loirooriol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant