Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt: fix compilation on linux #1

Merged
merged 3 commits into from Sep 20, 2015

Conversation

Projects
None yet
2 participants
@dhead666
Copy link
Contributor

dhead666 commented Aug 2, 2015

This commit fix compilation on my system, Arch Linux, x86_64.

@dhead666

This comment has been minimized.

Copy link
Contributor Author

dhead666 commented Aug 2, 2015

I'm far from expert but I updated CMakeLists.txt, now I can build adsp.biquad.filters on my system (though I didn't tested the addon in kodi yet).

@dhead666

This comment has been minimized.

Copy link
Contributor Author

dhead666 commented Aug 2, 2015

@AchimTuran

This comment has been minimized.

Copy link
Owner

AchimTuran commented Aug 2, 2015

@dhead666 thanks for your work.

At the moment I'm very busy with GSoC, so I can't check the build on Windows.

I'm far from expert but I updated CMakeLists.txt

Me too, I'm still learning CMake.

@dhead666

This comment has been minimized.

Copy link
Contributor Author

dhead666 commented Aug 2, 2015

Indentation fixed.

@dhead666

This comment has been minimized.

Copy link
Contributor Author

dhead666 commented Aug 7, 2015

@AchimTuran

I updated the PR, added UseMultiArch.cmake from Pulse-Eight's platform repo.

I kept the commit for adding the GCC flag separate, it should be removed if/when you'll change the preprocessor macro from #elif defined(TARGET_LINUX) to just else in order to cover all POSIX platforms.

@AchimTuran

This comment has been minimized.

Copy link
Owner

AchimTuran commented Aug 7, 2015

Hey thanks for your work. Looks good, but before merge it I will test it with my windows- and my linux machine.

I hope it is okay for that the merge will be next month. Sorry currently I'm very busy.

AchimTuran added a commit that referenced this pull request Sep 20, 2015

Merge pull request #1 from dhead666/fix_linux
CMakeLists.txt: fix compilation on linux

@AchimTuran AchimTuran merged commit ef228e4 into AchimTuran:master Sep 20, 2015

AchimTuran added a commit that referenced this pull request Nov 29, 2015

Merge pull request #1 from AlwinEsch/fix-os-builds
add usage of -fPIC for OS other then linux to fix library build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.