New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Process With Process Instance Name via rest and Java APIs #1952

Closed
salaboy opened this Issue Jul 30, 2018 · 6 comments

Comments

4 participants
@salaboy
Copy link
Member

salaboy commented Jul 30, 2018

We should be able to start a process instance with an associated name.

@salaboy salaboy added this to the Beta2 milestone Jul 30, 2018

@salaboy salaboy added this to Open in Activiti 7.x via automation Jul 30, 2018

@mauriziovitale

This comment has been minimized.

Copy link

mauriziovitale commented Oct 8, 2018

for my point of view the name should be mandatory

@salaboy salaboy added the blocking label Oct 8, 2018

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Oct 8, 2018

I disagree, there are situations where you don't want to set a name and it also adds an extra step for the user, we should automate this when possible, probably in the modeling app.

@erdemedeiros

This comment has been minimized.

Copy link
Member

erdemedeiros commented Oct 26, 2018

@lucianoprea I merged the PR on query-service, but it will be great if you can add this check in the acceptance tests as well.

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Nov 9, 2018

@lucianoprea this was tested with beta3 pre released artifacts and the problem seems to be in query not reflecting this information. I guess that there is a PR missing in query to apply the name based on the events information.

erdemedeiros added a commit to Activiti/activiti-cloud-runtime-bundle-service that referenced this issue Nov 12, 2018

Add test for process instance with name
Check that sent event has name set
Refs Activiti/Activiti#1952

@salaboy salaboy added the WIP label Nov 12, 2018

salaboy added a commit to Activiti/activiti-cloud-runtime-bundle-service that referenced this issue Nov 23, 2018

Add test for process instance with name (#144)
Check that sent event has name set
Refs Activiti/Activiti#1952
@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Dec 3, 2018

@miguelruizdev missing ACC in scenarios repo.. The missing PR cannot be merged in that repo, it needs to be moved to acc-tests-scenarios

@salaboy salaboy modified the milestones: Beta4, Beta5 Dec 3, 2018

@erdemedeiros

This comment has been minimized.

Copy link
Member

erdemedeiros commented Dec 4, 2018

@miguelruizdev @lucianoprea in case the acceptance test is failing I've added a test checking that the information is sent in PROCESS_STARTED event, but it seems to be missing in PROCESS_CREATED event. So you may need to update the information in ProcessStartedEventHandler

@salaboy salaboy modified the milestones: Beta5, Beta4 Dec 6, 2018

erdemedeiros added a commit to Activiti/activiti-cloud-query-service that referenced this issue Dec 6, 2018

Set process instance name
Process instance name is not available in ProcessCreatedEvent, so we need to update it in ProcessStartedEventHandler
Refs Activiti/Activiti#1952

mergify bot added a commit to Activiti/activiti-cloud-query-service that referenced this issue Dec 6, 2018

Set process instance name (#142)
Process instance name is not available in ProcessCreatedEvent, so we need to update it in ProcessStartedEventHandler
Refs Activiti/Activiti#1952

@salaboy salaboy closed this Dec 11, 2018

Activiti 7.x automation moved this from Open to Closed Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment