New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Business key in list of tasks #1970

Open
krishnashum opened this Issue Aug 20, 2018 · 12 comments

Comments

4 participants
@krishnashum
Copy link

krishnashum commented Aug 20, 2018

I think it would be good to have the business key to be a part of taskInfo, as In some scenarios the business key plays a vital role.

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Aug 21, 2018

@krishnashum +1, I think that we can easily add that in the new APIs that we released for beta1. Would you be interested in contributing back with those changes? It sounds like a great opportunity to get involved with the project. We are happy to guide you in the process.

@salaboy salaboy added this to Open in Activiti 7.x via automation Aug 21, 2018

@salaboy salaboy added this to the Beta2 milestone Aug 21, 2018

@krishnashum

This comment has been minimized.

Copy link

krishnashum commented Aug 22, 2018

sure. I will do the needful changes. Could you please provide some heads up on the process.

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Aug 22, 2018

@krishnashum I would recommend you to clone the activiti-examples project and then fork activiti-api and activiti repositories.
The behaviour that you want to implement needs to be added to the engine when creating a task. But in order to validate that the behaviour is correct we need to create first an example to demonstrate it. Please popup in the gitter channel and we can guide you further.

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Aug 24, 2018

@erdemedeiros this sounds like a short task for next week .

@salaboy salaboy modified the milestones: Beta2, RC1 Sep 14, 2018

@salaboy salaboy added the blocking label Oct 31, 2018

@salaboy salaboy modified the milestones: RC1, Beta3 Oct 31, 2018

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Oct 31, 2018

related to #2069

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Nov 1, 2018

@erdemedeiros this is a duplicate from @igdianov issue

@salaboy salaboy closed this Nov 1, 2018

Activiti 7.x automation moved this from Open to Closed Nov 1, 2018

@salaboy salaboy reopened this Nov 1, 2018

Activiti 7.x automation moved this from Closed to Open Nov 1, 2018

@salaboy salaboy added the api label Nov 7, 2018

@salaboy salaboy modified the milestones: Beta3, Beta4 Nov 9, 2018

@salaboy salaboy added the api-events label Nov 12, 2018

@igdianov igdianov self-assigned this Dec 6, 2018

@igdianov

This comment has been minimized.

Copy link
Member

igdianov commented Dec 6, 2018

@salaboy I have investigated and made initial spike to explore the scope of the changes required to add support process instance businessKey attribute in Tasks. At the top of the chain we will need to modify acitiviti-api. In Activiti core, we will need to create business key persistent attribute mapping in persistence layer to store it as part of task record across all supported databases in Activiti core.

Then, we will also need to support updating business key in related tasks when someone updates process instance business key.

Then, we will also need to add support for cloud events api and cloud services (audit, query)

@salaboy salaboy modified the milestones: Beta4, Beta5 Dec 6, 2018

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Dec 11, 2018

@igdianov after our discussion, I think that we should solve this only in the Query services, where we have all the data, that will avoid any major change in the RB.

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Jan 2, 2019

initial check at process level for business key in events: Activiti/activiti-cloud-runtime-bundle-service#174

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Jan 2, 2019

@igdianov we merged the events decoration with metadata such as business key.. should this be solved already?

@azureforaps2x-jx-bot

This comment has been minimized.

Copy link

azureforaps2x-jx-bot commented Jan 4, 2019

@salaboy I agree, we can solve this problem in the query service with businessKey propagated in the events.

@salaboy salaboy removed this from the Beta5 milestone Jan 7, 2019

@salaboy salaboy added this to the RC1 milestone Jan 7, 2019

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Jan 7, 2019

@igdianov you have too many jx bots accounts ;)

@salaboy salaboy added the priority1 label Jan 8, 2019

@salaboy salaboy modified the milestones: RC1, GA Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment