New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcessRuntime autodeploy process behaviour too aggressive #2138

Closed
salaboy opened this Issue Nov 9, 2018 · 3 comments

Comments

2 participants
@salaboy
Copy link
Member

salaboy commented Nov 9, 2018

The current behaviour of the Activiti Spring configuration is to automatically deploy the process definitions located inside the /processes/ directory. This behaviour works well when all the process definitions are valid, but if a single process has any parsing problems (standard xml schema validation) the whole runtime fail to start.

The expected behaviour should be:

  • Log and expose (actuator) the correctly deployed process definitions with clear keys and names
  • Log and expose (actuator) the processes that were not deployed and the errors causing the failure to deploy
  • The Runtime should start if there is at least a process definition deployed
  • The user should be able to parameterise when to fail
    • fail on the first error
    • fail on no process definition
    • never fail (for the case where the application might be providing other functionality besides process endpoints)

Example process that cause the runtime not to start today: https://github.com/salaboy/bpmn-scenarios/blob/master/processes/ServiceTask%20without%20Implementation.bpmn20.xml

@salaboy salaboy added this to the Beta3 milestone Nov 9, 2018

@salaboy salaboy added this to Open in Activiti 7.x via automation Nov 9, 2018

@salaboy salaboy modified the milestones: Beta3, Beta4 Nov 9, 2018

@salaboy salaboy modified the milestones: Beta4, Beta5 Dec 4, 2018

@daisuke-yoshimoto daisuke-yoshimoto self-assigned this Dec 8, 2018

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Dec 27, 2018

@daisuke-yoshimoto amazing stuff! now we need to make sure that we use a sensible default in the RB project.

@daisuke-yoshimoto

This comment has been minimized.

Copy link
Member

daisuke-yoshimoto commented Dec 27, 2018

@salaboy Ok. I will apply optin to rb in the following issue.
#2315

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Dec 27, 2018

initial work done by @daisuke-yoshimoto merged into develop

@salaboy salaboy closed this Dec 27, 2018

Activiti 7.x automation moved this from Open to Closed Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment