New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make process definitions available in query #2149

Closed
erdemedeiros opened this Issue Nov 12, 2018 · 5 comments

Comments

2 participants
@erdemedeiros
Member

erdemedeiros commented Nov 12, 2018

Currently it's not possible to retrieve process definitions from query as events related to process deployment are not being sent by the runtime bundle.

  • send event from runtime bundle
  • handle event in query
  • expose query user endpoint
  • expose query admin endpoint
  • handle event in audit
  • write acceptance test

Note: Events will be sent when the Spring Boot application is ready (ApplicationReadyEvent). A ProcessDeployedEvent will be triggered for every process deployed every time the application starts. Listeners should be able do deal with duplicates.

@erdemedeiros erdemedeiros created this issue from a note in Activiti 7.x (Open) Nov 12, 2018

@erdemedeiros erdemedeiros added this to the Beta4 milestone Nov 12, 2018

@erdemedeiros erdemedeiros added the api label Nov 12, 2018

@erdemedeiros erdemedeiros self-assigned this Nov 12, 2018

@erdemedeiros erdemedeiros moved this from Open to In Progress in Activiti 7.x Nov 12, 2018

@salaboy

This comment has been minimized.

Member

salaboy commented Nov 14, 2018

some other notes that might be relevant at this point:

  1. We shouldn't use Engine events, we can use Spring Boot events to wait for the application to start to send the events
  2. we should send in the events the application name and metadata so other services such as query can check if they have information about this app already
  3. on the producer side we should add the timestamp for the event when it is emitted
  4. we need a new event in API to represent this information

We need to externalise this information because we cannot rely on the RB to be up to get this information. UIs and "readers" should be able to rely on Query.
On the consume side we need:

  1. receive the new events and store the information
  2. update the modified time if we receive an event from an application that we already know about

Open questions:

  1. what do we do with the models themselves? process definitions xmls.. do we need to send them as part of the events?
@salaboy

This comment has been minimized.

Member

salaboy commented Nov 19, 2018

@erdemedeiros I think that we need to add to this issue that this endpoint should be enabled in the user and admin APIs of Query.

@erdemedeiros

This comment has been minimized.

Member

erdemedeiros commented Nov 19, 2018

@salaboy I updated the description accordingly.

erdemedeiros added a commit to Activiti/activiti-api that referenced this issue Nov 19, 2018

erdemedeiros added a commit that referenced this issue Nov 19, 2018

Trigger process deployed events
The events will be sent when the Spring Boot application is ready (ApplicationReadyEvent). A ProcessDeployedEvent will be triggered for every process deployed every time the application starts. Listeners to these events should be able do deal with duplicates.

Refs #2149

erdemedeiros added a commit to Activiti/activiti-cloud-api that referenced this issue Nov 19, 2018

erdemedeiros added a commit to Activiti/activiti-cloud-runtime-bundle-service that referenced this issue Nov 19, 2018

Trigger process deployed events
The events will be sent when the Spring Boot application is ready (ApplicationReadyEvent). A message grouping ProcessDeployedEvents will be triggered every time the application starts. Listeners to these events should be able do deal with duplicates.

Refs Activiti/Activiti#2149

erdemedeiros added a commit that referenced this issue Nov 21, 2018

Trigger process deployed events
The events will be sent when the Spring Boot application is ready (ApplicationReadyEvent). A ProcessDeployedEvent will be triggered for every process deployed every time the application starts. Listeners to these events should be able do deal with duplicates.

Refs #2149

erdemedeiros added a commit that referenced this issue Nov 21, 2018

Trigger process deployed events
The events will be sent when the Spring Boot application is ready (ApplicationReadyEvent). A ProcessDeployedEvent will be triggered for every process deployed every time the application starts. Listeners to these events should be able do deal with duplicates.

Refs #2149

salaboy added a commit that referenced this issue Nov 21, 2018

Trigger process deployed events (#2174)
* Trigger process deployed events

The events will be sent when the Spring Boot application is ready (ApplicationReadyEvent). A ProcessDeployedEvent will be triggered for every process deployed every time the application starts. Listeners to these events should be able do deal with duplicates.

Refs #2149

* Fix transitive dependencies

* Fix integration test

events coming from `WebEnvironment.MOCK` are ignored. So we need to use MOCK here.

erdemedeiros added a commit to Activiti/activiti-cloud-service-common that referenced this issue Nov 22, 2018

erdemedeiros added a commit to Activiti/activiti-cloud-query-service that referenced this issue Nov 22, 2018

salaboy added a commit to Activiti/activiti-cloud-api that referenced this issue Nov 23, 2018

erdemedeiros added a commit to Activiti/activiti-cloud-query-service that referenced this issue Nov 23, 2018

erdemedeiros added a commit to Activiti/activiti-cloud-query-service that referenced this issue Nov 23, 2018

salaboy added a commit to Activiti/activiti-cloud-query-service that referenced this issue Nov 23, 2018

@salaboy

This comment has been minimized.

Member

salaboy commented Nov 25, 2018

@erdemedeiros are only the acceptance tests missing for this one?
I would put that as high priority. So we can close this one in Beta4

erdemedeiros added a commit to Activiti/activiti-cloud-runtime-bundle-service that referenced this issue Nov 26, 2018

Trigger process deployed events
The events will be sent when the Spring Boot application is ready (ApplicationReadyEvent). A message grouping ProcessDeployedEvents will be triggered every time the application starts. Listeners to these events should be able do deal with duplicates.

Refs Activiti/Activiti#2149
@erdemedeiros

This comment has been minimized.

Member

erdemedeiros commented Nov 26, 2018

@salaboy you missed the PR for the runtime-bundle in the list above: Activiti/activiti-cloud-runtime-bundle-service#151. I'm working on acceptance tests.

erdemedeiros added a commit to Activiti/activiti-cloud-runtime-bundle-service that referenced this issue Nov 27, 2018

Trigger process deployed events (#151)
The events will be sent when the Spring Boot application is ready (ApplicationReadyEvent). A message grouping ProcessDeployedEvents will be triggered every time the application starts. Listeners to these events should be able do deal with duplicates.

Refs Activiti/Activiti#2149

erdemedeiros added a commit to Activiti/activiti-cloud-acceptance-scenarios that referenced this issue Nov 30, 2018

Activiti 7.x automation moved this from In Progress to Closed Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment