New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Maven Deploy plugin configuration for multi-module projects #2172

Closed
igdianov opened this Issue Nov 18, 2018 · 2 comments

Comments

2 participants
@igdianov
Member

igdianov commented Nov 18, 2018

It is best practice in multi-module Maven projects to deploy artifacts at the the end of the successful reactor build, so that if any of the module builds fail, none of the reactor projects is deployed.

In Jenkins-X release pipelines, the multi-module artifacts are deployed into activiti-releases Nexus repository. The <deployAtEnd> configuration will ensure that deployment is done atomically similar to Maven release workflow into Maven Central.

  <build>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-deploy-plugin</artifactId>
        <version>2.8.2</version>
        <configuration>
          <deployAtEnd>true</deployAtEnd>
        </configuration>
      </plugin>
    </plugins>
  </build>

@salaboy salaboy added this to Open in Activiti 7.x via automation Nov 19, 2018

@salaboy salaboy added this to the Beta4 milestone Nov 19, 2018

@salaboy salaboy self-assigned this Nov 19, 2018

@salaboy

This comment has been minimized.

Member

salaboy commented Nov 19, 2018

@igdianov should we add this everywhere? Should we start at the Activiti Core level?

@salaboy salaboy added the WIP label Nov 19, 2018

This was referenced Nov 23, 2018

@igdianov

This comment has been minimized.

Member

igdianov commented Nov 29, 2018

Done.

@igdianov igdianov closed this Nov 29, 2018

Activiti 7.x automation moved this from Open to Closed Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment