New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing id for BPMNElement #2175

Closed
erdemedeiros opened this Issue Nov 19, 2018 · 3 comments

Comments

3 participants
@erdemedeiros
Member

erdemedeiros commented Nov 19, 2018

BPMNElement should provide a getId() method.

The value should be set in the related converters:

@erdemedeiros erdemedeiros created this issue from a note in Activiti 7.x (Open) Nov 19, 2018

@erdemedeiros erdemedeiros added this to the Beta4 milestone Nov 19, 2018

@erdemedeiros

This comment has been minimized.

Member

erdemedeiros commented Nov 19, 2018

Blocks #2165

@salaboy

This comment has been minimized.

Member

salaboy commented Nov 20, 2018

@CTI777 To make this issue more explicit, we need to move one level up the method getElementId() from BPMNActivity to BPMNElement, so SequenceFlow can also have the getElementId() method.

salaboy added a commit that referenced this issue Nov 22, 2018

Missing id for BPMNElement #2175 (#2194)
* fix: SequenceFlowImpl => BPMNSequenceFlowImpl

* fix: import file added
@salaboy

This comment has been minimized.

Member

salaboy commented Nov 25, 2018

@erdemedeiros @CTI777 I will close this one because it is merged

@salaboy salaboy closed this Nov 25, 2018

Activiti 7.x automation moved this from Open to Closed Nov 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment