Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated swagger for rb-my-app:startProcess api request is missing payload type #2456

Closed
rpopa opened this Issue Feb 6, 2019 · 10 comments

Comments

5 participants
@rpopa
Copy link

rpopa commented Feb 6, 2019

After I generated using open feign the api client for activiti process runtime, I found out that the startProcess request is missing payloadType and it can't be used.

Stacktrace: "status":400,"error":"Bad Request","message":"JSON parse error: Missing type id when trying to resolve subtype of [simple type, class org.activiti.api.process.model.payloads.StartProcessPayload]: missing type id property 'payloadType'; nested exception is com.fasterxml.jackson.databind.exc.InvalidTypeIdException: Missing type id when trying to resolve subtype of [simple type, class org.activiti.api.process.model.payloads.StartProcessPayload]: missing type id property 'payloadType'\n at [Source: (PushbackInputStream); line: 1, column: 193]","path":"/admin/v1/process-instances"}

@salaboy salaboy added this to Open in Activiti 7.x via automation Feb 7, 2019

@salaboy salaboy added this to the 1.1 milestone Feb 7, 2019

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Feb 7, 2019

@rpopa thanks for reporting this, we are aware of the issue, but it seems to be a problem of swagger and polymorphism. We are investigating the issue to see if we can fix it in the short term.

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Feb 13, 2019

@mteodori I think that those are working but not being picked up by swagger

@mteodori

This comment has been minimized.

Copy link
Member

mteodori commented Feb 14, 2019

@salaboy yes that is what I meant, swagger configuration is not the same as the app one

@constantin-ciobotaru constantin-ciobotaru self-assigned this Feb 15, 2019

constantin-ciobotaru added a commit to Activiti/activiti-cloud-runtime-bundle-service that referenced this issue Feb 18, 2019

@constantin-ciobotaru

This comment has been minimized.

Copy link
Collaborator

constantin-ciobotaru commented Feb 18, 2019

I've added an workaround for this: Activiti/activiti-cloud-runtime-bundle-service#248

A proper fix would be to update springfox to pickup the jackson mixin config.

constantin-ciobotaru added a commit to Activiti/activiti-cloud-runtime-bundle-service that referenced this issue Feb 18, 2019

@ouyangshixiong

This comment has been minimized.

Copy link

ouyangshixiong commented Feb 18, 2019

I think it's nothing deal with swagger,postman return the same error .
1550483739 1

@mteodori

This comment has been minimized.

Copy link
Member

mteodori commented Feb 18, 2019

@ouyangshixiong I believe the postman collection hasn't been updated in a while, can you create a separate issue for that? thanks

constantin-ciobotaru added a commit to Activiti/activiti-cloud-runtime-bundle-service that referenced this issue Feb 18, 2019

constantin-ciobotaru added a commit to Activiti/activiti-cloud-runtime-bundle-service that referenced this issue Feb 18, 2019

@ouyangshixiong

This comment has been minimized.

Copy link

ouyangshixiong commented Feb 18, 2019

constantin-ciobotaru added a commit to Activiti/activiti-cloud-runtime-bundle-service that referenced this issue Feb 18, 2019

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Feb 18, 2019

@ouyangshixiong instead of CommandType -> PayloadType and then
StartProcessPayload is the payload for that request.. that should work.
We will probably not maintain Postman collections as they go out of date quite fast. We will favour swagger and swagger files aggregations in the future, which you can also import in Postman

salaboy added a commit to Activiti/activiti-cloud-runtime-bundle-service that referenced this issue Feb 19, 2019

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Feb 19, 2019

fixed merge in develop

@salaboy salaboy closed this Feb 19, 2019

Activiti 7.x automation moved this from Open to Closed Feb 19, 2019

salaboy added a commit to Activiti/activiti-cloud-runtime-bundle-service that referenced this issue Feb 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.