Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong JSON format for Process Extensions variable mappings #2483

Closed
salaboy opened this Issue Feb 11, 2019 · 5 comments

Comments

2 participants
@salaboy
Copy link
Member

salaboy commented Feb 11, 2019

Currently the Front End Application is generating:

"extensions": {
        "variablesMappings": {
            "Task_1u6he83": {
                "input": {
                    "a": "b"
                },
                "output": {
                    "c": "d"
                }
            }
        },

and the output should be like shown in this PR for the backend to work:
https://github.com/Activiti/Activiti/pull/2227/files#diff-598aca14897d5c0c5a523a3c039be619R55

"extensions": {
    "mappings": {
	      "serviceTask": {
	        "inputs": {
	         ...
	        },
	        "outputs": {
	         ...
	        }
	      }

Don't pay attention to the indentation.. just the names.

@salaboy salaboy added this to Open in Activiti 7.x via automation Feb 11, 2019

@salaboy salaboy added this to the GA milestone Feb 11, 2019

@salaboy salaboy added the priority1 label Feb 11, 2019

constantin-ciobotaru added a commit to Activiti/activiti-cloud-org-service that referenced this issue Feb 12, 2019

2483 Fix process variables format
- rename extensions variablesMapping to mappings
- rename input and output to inputs and outputs
- update tests

Activiti/Activiti#2483

mergify bot added a commit to Activiti/activiti-cloud-org-service that referenced this issue Feb 12, 2019

2483 Fix process variables format (#155)
- rename extensions variablesMapping to mappings
- rename input and output to inputs and outputs
- update tests

Activiti/Activiti#2483
@magemello

This comment has been minimized.

Copy link
Member

magemello commented Feb 12, 2019

this is the format....are we implementing this?

"mappings": {
    "Task_1hkl8bn": {
      "input": {
        "726478cc-91ac-40bb-8f3c-f0782ab81af0": {
          "type": "variable",
          "value": "5e4947c2-d263-4b86-ab98-5627ff5f461a"
        },
        "33ec3b54-90ff-4a97-91be-178976a4dd26": {
          "type": "value",
          // not process variable, comes from the connector configuration, BE magic
          "value": "${host}"
        }
      }
    }
  }
@salaboy

This comment has been minimized.

Copy link
Member Author

salaboy commented Feb 12, 2019

@magemello well. .input needs to be inputs and output needs to be outputs

@magemello

This comment has been minimized.

Copy link
Member

magemello commented Feb 12, 2019

Ok then....is:

"mappings": {
    "Task_1hkl8bn": {
      "inputs": {
        "726478cc-91ac-40bb-8f3c-f0782ab81af0": {
          "type": "variable",
          "value": "5e4947c2-d263-4b86-ab98-5627ff5f461a"
        },
        "33ec3b54-90ff-4a97-91be-178976a4dd26": {
          "type": "value",
          // not process variable, comes from the connector configuration, BE magic
          "value": "${host}"
        }
      },
    "outputs": {
    }
  }
@salaboy

This comment has been minimized.

Copy link
Member Author

salaboy commented Feb 12, 2019

@salaboy

This comment has been minimized.

Copy link
Member Author

salaboy commented Feb 13, 2019

merged in develop

@salaboy salaboy closed this Feb 13, 2019

Activiti 7.x automation moved this from Open to Closed Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.