Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET Task variable on the query service is not sync with the runtimebundle service #2514

Closed
mauriziovitale opened this Issue Feb 15, 2019 · 9 comments

Comments

4 participants
@mauriziovitale
Copy link

mauriziovitale commented Feb 15, 2019

the query and rb endpoint related to the variables are not in sync

http://{{domain}}/{{applicationName}}-rb/v1/tasks/9b45d1eb-3111-11e9-859a-0a586460013b/variables

{
    "links": [],
    "content": [
        {
            "appName": "simple-app",
            "appVersion": "",
            "serviceName": "simple-app-rb",
            "serviceFullName": "simple-app-rb",
            "serviceType": "runtime-bundle",
            "serviceVersion": "",
            "name": "firstName",
            "type": "string",
            "taskId": "9b45d1eb-3111-11e9-859a-0a586460013b",
            "value": "Maurizio",
            "taskVariable": true
        }
    ]
}

http://{{domain}}/{{applicationName}}-query/v1/tasks/9b45d1eb-3111-11e9-859a-0a586460013b/variables

{
    "list": {
        "entries": [],
        "pagination": {
            "skipCount": 0,
            "maxItems": 100,
            "count": 0,
            "hasMoreItems": false,
            "totalItems": 0
        }
    }
}

Same response applyed for admin endpoint
http://{{domain}}/{{applicationName}}-query/admin/v1/tasks/9b45d1eb-3111-11e9-859a-0a586460013b/variables

Step to reproduce it

Create a stand alone task
SetTaskVariables
Get the task variables using rb service
Get the task variables using query service

@salaboy salaboy added this to Open in Activiti 7.x via automation Feb 15, 2019

@salaboy salaboy added this to the 1.1 milestone Feb 15, 2019

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Feb 15, 2019

@mauriziovitale why is this failing now? was this working before with Beta4, Beta5, RC1?

@mauriziovitale

This comment has been minimized.

Copy link
Author

mauriziovitale commented Feb 15, 2019

@salaboy the API has been released with RC1 and not with beta4
(#2182)
This is the first time we have a chance to test it after we have been asked to use the admin endpoint. Do you have an acceptance test for that?

@miguelruizdev

This comment has been minimized.

Copy link
Contributor

miguelruizdev commented Feb 15, 2019

Issue reproduced:
RB:

{
    "links": [],
    "content": [
        {
            "appName": "default-app",
            "appVersion": "",
            "serviceName": "rb-my-app",
            "serviceFullName": "rb-my-app",
            "serviceType": "runtime-bundle",
            "serviceVersion": "",
            "name": "firstName",
            "type": "string",
            "taskId": "080e8aa3-3131-11e9-b5dd-0a580a18105d",
            "value": "Paulo",
            "taskVariable": true,
            "links": [
                {
                    "rel": "variables",
                    "href": "http://rb-my-app/v1/tasks/080e8aa3-3131-11e9-b5dd-0a580a18105d/variables"
                },
                {
                    "rel": "task",
                    "href": "http://rb-my-app/v1/tasks/080e8aa3-3131-11e9-b5dd-0a580a18105d"
                },
                {
                    "rel": "home",
                    "href": "http://rb-my-app/v1"
                }
            ]
        },
        {
            "appName": "default-app",
            "appVersion": "",
            "serviceName": "rb-my-app",
            "serviceFullName": "rb-my-app",
            "serviceType": "runtime-bundle",
            "serviceVersion": "",
            "name": "lastName",
            "type": "string",
            "taskId": "080e8aa3-3131-11e9-b5dd-0a580a18105d",
            "value": "SilvaTest",
            "taskVariable": true,
            "links": [
                {
                    "rel": "variables",
                    "href": "http://rb-my-app/v1/tasks/080e8aa3-3131-11e9-b5dd-0a580a18105d/variables"
                },
                {
                    "rel": "task",
                    "href": "http://rb-my-app/v1/tasks/080e8aa3-3131-11e9-b5dd-0a580a18105d"
                },
                {
                    "rel": "home",
                    "href": "http://rb-my-app/v1"
                }
            ]
        },
        {
            "appName": "default-app",
            "appVersion": "",
            "serviceName": "rb-my-app",
            "serviceFullName": "rb-my-app",
            "serviceType": "runtime-bundle",
            "serviceVersion": "",
            "name": "age",
            "type": "integer",
            "taskId": "080e8aa3-3131-11e9-b5dd-0a580a18105d",
            "value": 25,
            "taskVariable": true,
            "links": [
                {
                    "rel": "variables",
                    "href": "http://rb-my-app/v1/tasks/080e8aa3-3131-11e9-b5dd-0a580a18105d/variables"
                },
                {
                    "rel": "task",
                    "href": "http://rb-my-app/v1/tasks/080e8aa3-3131-11e9-b5dd-0a580a18105d"
                },
                {
                    "rel": "home",
                    "href": "http://rb-my-app/v1"
                }
            ]
        }
    ]
}

Query:

{
    "list": {
        "entries": [],
        "pagination": {
            "skipCount": 0,
            "maxItems": 100,
            "count": 0,
            "hasMoreItems": false,
            "totalItems": 0
        }
    }
}
@miguelruizdev

This comment has been minimized.

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Feb 15, 2019

@mauriziovitale RC1 was closed in Jan https://github.com/Activiti/Activiti/milestone/11 , at least now we have the solution to the problem.. and Standalone tasks are always edge cases

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Feb 15, 2019

still not clear what the use case is.. it is quite hard to have acceptance tests for all the combinations if we don't understand in which context this is being used.

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Feb 16, 2019

@CTI777 yeah.. I think that @miguelruizdev just did that in a branch already.

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Feb 19, 2019

merged to develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.