Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acc scenarios not building in jx #2577

Closed
ryandawsonuk opened this Issue Feb 27, 2019 · 6 comments

Comments

2 participants
@ryandawsonuk
Copy link
Member

ryandawsonuk commented Feb 27, 2019

Getting error javac: invalid flag: --release

Really strange that this seems to have been failing for a while:
http://jenkins.jx.35.228.195.195.nip.io/job/Activiti/job/activiti-cloud-acceptance-scenarios/job/master/18/console

But the chart pipeline uses it and built it succesfully just recently: http://jenkins.jx.35.228.195.195.nip.io/job/Activiti/job/activiti-cloud-example-chart/job/master/22/console

It looks like somehow it is working in one pipeline and not in another. It does build for me locally.

There are actually no new commits since it started failing. The last commit was just before the last successful run.

So the difference between it working and not working might have been the jx cluster upgrade. But I've checked the maven build pod versions for the cluster and they are the same as the core one. Also the chart pipeline is working and that is in the same cluster.

@ryandawsonuk

This comment has been minimized.

Copy link
Member Author

ryandawsonuk commented Feb 27, 2019

I think modeling build is out of step here (develop for cloud and core both have 8) so have commited Activiti/activiti-cloud-modeling-build@f15d63f

@ryandawsonuk

This comment has been minimized.

Copy link
Member Author

ryandawsonuk commented Feb 27, 2019

@ryandawsonuk

This comment has been minimized.

Copy link
Member Author

ryandawsonuk commented Feb 27, 2019

@ryandawsonuk

This comment has been minimized.

Copy link
Member Author

ryandawsonuk commented Feb 27, 2019

After changing to an 11 build pod it does now build

11 jdk presumably needs to see the version as 8.
But an actual 8 jdk needs to see the version as 1.8.
So perversely we're doing an 8 build but mvn clean install would actually fail for one of our projects if you were using jdk8. That is what the invalid flag message means

I guess that is only a problem if we expect a project to be directly built using JDK8 and even in that case I guess you could set -Djava.version=1.8

@ryandawsonuk

This comment has been minimized.

Copy link
Member Author

ryandawsonuk commented Feb 27, 2019

So I've cherry-picked the Jenkinsfile fix to 7.0.x

And have got the pipelines running for this again. I think we can close this out now unless anyone disagrees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.