Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven build pods need renaming in Jenkinsfiles #2620

Closed
ryandawsonuk opened this Issue Mar 8, 2019 · 11 comments

Comments

3 participants
@ryandawsonuk
Copy link
Member

ryandawsonuk commented Mar 8, 2019

Our maven build pods are called maven-java11:

image

and this is referenced in our Jenkinsfiles

The JX guys have recently renamed this. We can simply change the name in our cluster configuration for internal builds but we tell people to fork our projects for ttc-workshop so @ouyangshixiong is now encountering issues with this as his new cluster has:

image

Interestingly the error encountered was ‘Jenkins’ doesn’t have label ‘maven-dind’ but the actual problem turned out to be that ‘maven-dind’ was trying to inherit from a build pod template whose name didn't match in that cluster

I think it will also affect quickstarts - https://github.com/Activiti/activiti-cloud-connector-quickstart/blob/master/Jenkinsfile#L3

@ryandawsonuk ryandawsonuk changed the title maven build pod names in Jenkinsfiles maven build pods need renaming in Jenkinsfiles Mar 8, 2019

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Mar 11, 2019

@ryandawsonuk this sounds like a low hanging fruit that can be solved now :)

@salaboy salaboy added this to Open in Activiti 7.x via automation Mar 11, 2019

@salaboy salaboy added this to the 7.1.0.M1 milestone Mar 11, 2019

@ryandawsonuk

This comment has been minimized.

Copy link
Member Author

ryandawsonuk commented Mar 15, 2019

Interestingly this doesn't affect the quickstarts. I created a new cluster and was able to get the quickstarts building fine. Yet the new cluster does indeed have the pod template name matching that reported by @ouyangshixiong

image

But renaming did resolve the problem faced by @ouyangshixiong:

image

So it must be that the problem only affects inheritFrom used for dind configurations. It seems that relies on the template name directly and not through the label.

This means we don't need to change quickstarts as they match to a build pod by label. But we do need to change all the other projects that build docker images (and change all of them at once) and also change the pod template in the jx admin console.

@ryandawsonuk

This comment has been minimized.

Copy link
Member Author

ryandawsonuk commented Mar 15, 2019

Also when we do this it will need to be changed in or cherry-picked to the 7.0.x branches or it would break the 7.0.x pipelines, when we have those running

ryandawsonuk added a commit to Activiti/ttc-connectors-processing that referenced this issue Mar 15, 2019

ryandawsonuk added a commit to Activiti/ttc-connectors-reward that referenced this issue Mar 15, 2019

ryandawsonuk added a commit to Activiti/example-runtime-bundle that referenced this issue Mar 15, 2019

ryandawsonuk added a commit to Activiti/ttc-campaigns-service that referenced this issue Mar 15, 2019

ryandawsonuk added a commit to Activiti/ttc-query-campaign that referenced this issue Mar 15, 2019

ryandawsonuk added a commit to Activiti/activiti-cloud-audit that referenced this issue Mar 15, 2019

ryandawsonuk added a commit to Activiti/activiti-cloud-notifications-graphql that referenced this issue Mar 15, 2019

ryandawsonuk added a commit to Activiti/activiti-cloud-query that referenced this issue Mar 15, 2019

ryandawsonuk added a commit to Activiti/activiti-cloud-modeling that referenced this issue Mar 15, 2019

ryandawsonuk added a commit to Activiti/example-cloud-connector that referenced this issue Mar 15, 2019

ryandawsonuk added a commit to Activiti/example-runtime-bundle that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/activiti-cloud-audit that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/activiti-cloud-notifications-graphql that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/activiti-cloud-query that referenced this issue Mar 18, 2019

@ryandawsonuk

This comment has been minimized.

Copy link
Member Author

ryandawsonuk commented Mar 18, 2019

The remaining part of this is the cherry-picking to 7.0.x

ryandawsonuk added a commit to Activiti/activiti-cloud-modeling that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/example-cloud-connector that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/ttc-connectors-processing that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/ttc-connectors-reward that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/example-runtime-bundle that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/ttc-campaigns-service that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/ttc-query-campaign that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/activiti-cloud-audit that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/activiti-cloud-notifications-graphql that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/activiti-cloud-query that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/activiti-cloud-modeling that referenced this issue Mar 18, 2019

ryandawsonuk added a commit to Activiti/example-cloud-connector that referenced this issue Mar 18, 2019

@ryandawsonuk

This comment has been minimized.

Copy link
Member Author

ryandawsonuk commented Mar 18, 2019

Now the commits (all changes to Jenkinsfiles) are also cherry-picked to the 7.0.x branches.

Activiti 7.x automation moved this from Open to Closed Mar 18, 2019

@ryandawsonuk

This comment has been minimized.

Copy link
Member Author

ryandawsonuk commented Mar 19, 2019

We're seeing builds get stuck waiting for agents on the examples cluster. Had to put the pod template back to maven-java11 in order to get the builds running. So this seems to need a bit more work.

@ryandawsonuk ryandawsonuk reopened this Mar 19, 2019

Activiti 7.x automation moved this from Closed to Open Mar 19, 2019

@ryandawsonuk

This comment has been minimized.

Copy link
Member Author

ryandawsonuk commented Mar 19, 2019

It seems the maven template is applied correctly to master branch but PRs still look for maven-java11, even though that isn't in the Jenkinsfile (not for master or the branch).

I suspect upgrading the cluster would resolve this but that would take a while so for now what I'm doing is simply duplicating the whole kubernetes build pod template. This allows the builds to all run correctly.

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Apr 11, 2019

@almerico I will close this.. but please feel free to re-open if this is still an issue

@salaboy salaboy closed this Apr 11, 2019

Activiti 7.x automation moved this from Open to Closed Apr 11, 2019

@ouyangshixiong

This comment has been minimized.

Copy link

ouyangshixiong commented Apr 16, 2019

@ryandawsonuk Thank you for your had work.
There are much much more problems setting up Jenkin X, anyway Private Jenkins X with Activiti Cloud cluster can be setuped.
Some problems are :
1. Jenkins X's docker images are very huge and updated frequently, it made the k8s cluster running in high IO situation( my k8s cluster only has two machines using VMWARE, one machine without SSD ).
2. Jenkins X's chartmusum was setup on google's server, it was not stable accessed in China(behind GFW)
3. If published onto the production env, The cluster may consume a lot of CPUs, SSD, you should consider cost.
4. Jenkins X only work fine with github.( There are too many bugs with gitlab or gitea ) It is not friendly to some business companies.
So I had to fall back to use activiti7 core + springboot + spring security to build my production applications.
Until now, All applications works file :)

If some guy want to set private cluster, you need these prerequisites :
1. At least 4 servers with 4GB memory each- one master, three nodes
2. SSD-40GB disk space each for local docker images
3. 150GB disk space for PVs
4. Very fast network access
5. VPN should be setup carefully if you are behind Firewalls(such as GFW). If you use VPN globally pulling images will be very very slowly.
6. docker mirror should be configed on every node to speed up your installation.
7. download your modeler activiti diagram, it may lost.( I can't belived it, But It really happened)

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Apr 16, 2019

@ouyangshixiong thanks a lot for your feedback. Some of this would be very valuable for the JenkinsX project. I believe that they have built something that is pluggable, so most of the issues you mention can be fixed (custom docker registry, other git providers, etc).
We are currently working hard to improve the modeler experience, at this stage is early access, so feedback is more than welcome.

@salaboy

This comment has been minimized.

Copy link
Member

salaboy commented Apr 16, 2019

@ouyangshixiong feel free to get in touch and share what you use case is if you want to join the community and help other people with common problems on kubernetes will be highly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.