[bug-fix]fix NPE when parsing some legal bpmn xml files by XenoAmess · Pull Request #3588 · Activiti/Activiti

XenoAmess · 2021-03-08T15:39:45Z

Hi.
Bpmn allows <collaboration> under <definition>.
and when <collaboration> have <extesionElements>, activiti will throw an NPE.
This is because activiti THOUGHT all <extesionElements> be under some process, but that is, actually, nonsence.

codecov · 2021-03-08T15:55:55Z

Codecov Report

Merging #3588 (83308ea) into develop (561a24f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             develop    #3588      +/-   ##
=============================================
+ Coverage      61.41%   61.43%   +0.02%     
- Complexity      1893     1894       +1     
=============================================
  Files           1343     1343              
  Lines          44126    44127       +1     
  Branches        6168     6169       +1     
=============================================
+ Hits           27099    27110      +11     
+ Misses         14200    14192       -8     
+ Partials        2827     2825       -2

Impacted Files	Coverage Δ	Complexity Δ
...bpmn/converter/parser/ExtensionElementsParser.java	`86.95% <100.00%> (+0.59%)`	`10.00 <0.00> (+1.00)`
...mpl/agenda/TakeOutgoingSequenceFlowsOperation.java	`89.80% <0.00%> (+1.27%)`	`0.00% <0.00%> (ø%)`
...mpl/asyncexecutor/AcquireAsyncJobsDueRunnable.java	`71.92% <0.00%> (+5.26%)`	`0.00% <0.00%> (ø%)`
...e/impl/asyncexecutor/AcquireTimerJobsRunnable.java	`78.18% <0.00%> (+5.45%)`	`0.00% <0.00%> (ø%)`
...xecutionsWithSameRootProcessInstanceIdMatcher.java	`37.50% <0.00%> (+12.50%)`	`0.00% <0.00%> (ø%)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 561a24f...83308ea. Read the comment docs.

XenoAmess · 2021-03-10T15:51:51Z

for an example:

<?xml version="1.0" encoding="UTF-8"?>
<definitions exporter="Visual Paradigm" exporterVersion="1" id="Definition" targetNamespace="http://www.omg.org/bpmn20" xmlns="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:omgdc="http://www.omg.org/spec/DD/20100524/DC" xmlns:omgdi="http://www.omg.org/spec/DD/20100524/DI" xmlns:vp="http://www.visual-paradigm.com/bpmn/vpspecificcontent" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.omg.org/spec/BPMN/20100524/MODEL http://www.omg.org/spec/BPMN/20100501/BPMN20.xsd">
	<collaboration id="collaboration-_1">
		<extensionElements>
			<vp:Extensions>
				<vp:DiagramExtension Idref="diagram-_1">
					<vp:VpId Value="TjYrOB6FYHQgAQWK"/>
					<vp:DiagramProperties>
						<vp:StringProperty Name="userID" Value="1"/>
						<vp:StringProperty Name="pmCreateDateTime" Value="1615391386737"/>
						<vp:StringProperty Name="pmLastModified" Value="1615391424183"/>
						<vp:DoubleProperty Name="teamworkCreateDateTime" Value="0"/>
						<vp:StringProperty Name="documentation_html" Value="&lt;html&gt;&#13;&#10;  &lt;head&gt;&#13;&#10;    &lt;style type=&quot;text/css&quot;&gt;&#10;      &lt;!--&#10;        body { color: #000000; font-family: Dialog; font-size: 12px }&#10;      --&gt;&#10;    &lt;/style&gt;&#13;&#10;    &#13;&#10;  &lt;/head&gt;&#13;&#10;  &lt;body&gt;&#13;&#10;    &lt;p&gt;&#13;&#10;      &#13;&#10;    &lt;/p&gt;&#13;&#10;  &lt;/body&gt;&#13;&#10;&lt;/html&gt;&#13;&#10;"/>
						<vp:IntegerProperty Name="connectorStyle" Value="5"/>
						<vp:IntegerProperty Name="connectionPointStyle" Value="1"/>
						<vp:BooleanProperty Name="maximized" Value="true"/>
						<vp:IntegerProperty Name="x" Value="0"/>
						<vp:IntegerProperty Name="y" Value="0"/>
						<vp:IntegerProperty Name="width" Value="982"/>
						<vp:IntegerProperty Name="height" Value="597"/>
						<vp:StringArrayProperty Name="customizedSortDiagramElementIds">
							<vp:Values>
								<vp:Value Value="ID_65415653_1601_7205_3007_204000200006"/>
								<vp:Value Value="ID_65415653_1601_7205_3007_204000200007"/>
							</vp:Values>
						</vp:StringArrayProperty>
					</vp:DiagramProperties>
				</vp:DiagramExtension>
				<vp:DiagramElementExtension Idref="ID_51415653_1601_7205_3007_204000200001">
					<vp:VpId Value="q_ErOB6FYHQgAQWk"/>
					<vp:ShapeType Value="BPStartEvent"/>
					<vp:DiagramElementProperties>
						<vp:IntegerProperty Name="zOrder" Value="6"/>
						<vp:ColorProperty Name="background" Value="-8728587"/>
						<vp:ColorProperty Name="foreground" Value="-16777216"/>
						<vp:IntegerProperty Name="parentConnectorHeaderLength" Value="40"/>
						<vp:IntegerProperty Name="parentConnectorLineLength" Value="10"/>
						<vp:BooleanProperty Name="connectToPoint" Value="true"/>
						<vp:DoubleProperty Name="parentConnectorDTheta" Value="0.0"/>
						<vp:BooleanProperty Name="coverConnector" Value="false"/>
						<vp:BooleanProperty Name="requestDefaultSize" Value="false"/>
						<vp:IntegerProperty Name="0cpPlct" Value="10"/>
					</vp:DiagramElementProperties>
					<vp:ElementFont Color="-16777216" Name="Dialog" Size="11" Style="0"/>
					<vp:Line Cap="0" Color="-16777216" Transparency="0" Weight="1.0">
						<vp:Stroke/>
					</vp:Line>
					<vp:Caption Height="0" InternalHeight="-2147483648" InternalWidth="-2147483648" Side="1" Visible="true" Width="20" X="122" Y="251"/>
					<vp:FillColor Color1="-3934854" Style="1" Transparency="0" Type="1"/>
				</vp:DiagramElementExtension>
				<vp:DiagramElementExtension Idref="ID_71415653_1601_7205_3007_204000200002">
					<vp:VpId Value="iZkrOB6FYHQgAQWt"/>
					<vp:ShapeType Value="BPTask"/>
					<vp:DiagramElementProperties>
						<vp:IntegerProperty Name="zOrder" Value="4"/>
						<vp:ColorProperty Name="background" Value="-8728587"/>
						<vp:ColorProperty Name="foreground" Value="-16777216"/>
						<vp:IntegerProperty Name="parentConnectorHeaderLength" Value="40"/>
						<vp:IntegerProperty Name="parentConnectorLineLength" Value="10"/>
						<vp:BooleanProperty Name="connectToPoint" Value="true"/>
						<vp:DoubleProperty Name="parentConnectorDTheta" Value="0.0"/>
						<vp:BooleanProperty Name="coverConnector" Value="false"/>
						<vp:BooleanProperty Name="requestDefaultSize" Value="false"/>
					</vp:DiagramElementProperties>
					<vp:ElementFont Color="-16777216" Name="Dialog" Size="11" Style="0"/>
					<vp:Line Cap="0" Color="-16777216" Transparency="0" Weight="1.0">
						<vp:Stroke/>
					</vp:Line>
					<vp:Caption Height="40" InternalHeight="-2147483648" InternalWidth="-2147483648" Side="12" Visible="true" Width="50" X="0" Y="0"/>
					<vp:FillColor Color1="-1116806" Style="1" Transparency="0" Type="1"/>
				</vp:DiagramElementExtension>
				<vp:DiagramElementExtension Idref="ID_05415653_1601_7205_3007_204000200003">
					<vp:VpId Value="Q_krOB6FYHQgAQXB"/>
					<vp:ShapeType Value="BPSequenceFlow"/>
					<vp:DiagramElementProperties>
						<vp:IntegerProperty Name="zOrder" Value="12"/>
						<vp:IntegerProperty Name="x" Value="82"/>
						<vp:IntegerProperty Name="y" Value="197"/>
						<vp:IntegerProperty Name="width" Value="206"/>
						<vp:IntegerProperty Name="height" Value="123"/>
						<vp:ColorProperty Name="background" Value="-16777216"/>
						<vp:ColorProperty Name="foreground" Value="-16777216"/>
						<vp:IntegerProperty Name="fromShapeXDiff" Value="0"/>
						<vp:IntegerProperty Name="fromShapeYDiff" Value="0"/>
						<vp:IntegerProperty Name="toShapeXDiff" Value="0"/>
						<vp:IntegerProperty Name="toShapeYDiff" Value="0"/>
						<vp:IntegerProperty Name="fromConnectType" Value="0"/>
						<vp:IntegerProperty Name="toConnectType" Value="0"/>
						<vp:BooleanProperty Name="useFromShapeCenter" Value="true"/>
						<vp:BooleanProperty Name="useToShapeCenter" Value="true"/>
					</vp:DiagramElementProperties>
					<vp:ElementFont Color="-16777216" Name="Dialog" Size="11" Style="0"/>
					<vp:Line Cap="0" Color="-16777216" Transparency="0" Weight="1.0">
						<vp:Stroke/>
					</vp:Line>
					<vp:Caption Height="0" InternalHeight="-2147483648" InternalWidth="-2147483648" Side="1" Visible="true" Width="20" X="175" Y="269"/>
					<vp:ConnectorStyle Value="3"/>
				</vp:DiagramElementExtension>
				<vp:DiagramElementExtension Idref="ID_45415653_1601_7205_3007_204000200004">
					<vp:VpId Value="jJUrOB6FYHQgAQXN"/>
					<vp:ShapeType Value="BPEndEvent"/>
					<vp:DiagramElementProperties>
						<vp:IntegerProperty Name="zOrder" Value="2"/>
						<vp:ColorProperty Name="background" Value="-8728587"/>
						<vp:ColorProperty Name="foreground" Value="-16777216"/>
						<vp:IntegerProperty Name="parentConnectorHeaderLength" Value="40"/>
						<vp:IntegerProperty Name="parentConnectorLineLength" Value="10"/>
						<vp:BooleanProperty Name="connectToPoint" Value="true"/>
						<vp:DoubleProperty Name="parentConnectorDTheta" Value="0.0"/>
						<vp:BooleanProperty Name="coverConnector" Value="false"/>
						<vp:BooleanProperty Name="requestDefaultSize" Value="false"/>
						<vp:IntegerProperty Name="0cpPlct" Value="10"/>
					</vp:DiagramElementProperties>
					<vp:ElementFont Color="-16777216" Name="Dialog" Size="11" Style="0"/>
					<vp:Line Cap="0" Color="-16777216" Transparency="0" Weight="3.0">
						<vp:Stroke/>
					</vp:Line>
					<vp:Caption Height="0" InternalHeight="-2147483648" InternalWidth="-2147483648" Side="1" Visible="true" Width="20" X="381" Y="302"/>
					<vp:FillColor Color1="-689542" Style="1" Transparency="0" Type="1"/>
				</vp:DiagramElementExtension>
				<vp:DiagramElementExtension Idref="ID_25415653_1601_7205_3007_204000200005">
					<vp:VpId Value="C_UrOB6FYHQgAQXe"/>
					<vp:ShapeType Value="BPSequenceFlow"/>
					<vp:DiagramElementProperties>
						<vp:IntegerProperty Name="zOrder" Value="14"/>
						<vp:IntegerProperty Name="x" Value="239"/>
						<vp:IntegerProperty Name="y" Value="220"/>
						<vp:IntegerProperty Name="width" Value="201"/>
						<vp:IntegerProperty Name="height" Value="108"/>
						<vp:ColorProperty Name="background" Value="-16777216"/>
						<vp:ColorProperty Name="foreground" Value="-16777216"/>
						<vp:IntegerProperty Name="fromShapeXDiff" Value="0"/>
						<vp:IntegerProperty Name="fromShapeYDiff" Value="0"/>
						<vp:IntegerProperty Name="toShapeXDiff" Value="0"/>
						<vp:IntegerProperty Name="toShapeYDiff" Value="0"/>
						<vp:IntegerProperty Name="fromConnectType" Value="0"/>
						<vp:IntegerProperty Name="toConnectType" Value="0"/>
						<vp:BooleanProperty Name="useFromShapeCenter" Value="true"/>
						<vp:BooleanProperty Name="useToShapeCenter" Value="true"/>
					</vp:DiagramElementProperties>
					<vp:ElementFont Color="-16777216" Name="Dialog" Size="11" Style="0"/>
					<vp:Line Cap="0" Color="-16777216" Transparency="0" Weight="1.0">
						<vp:Stroke/>
					</vp:Line>
					<vp:Caption Height="0" InternalHeight="-2147483648" InternalWidth="-2147483648" Side="1" Visible="true" Width="20" X="329" Y="269"/>
					<vp:ConnectorStyle Value="3"/>
				</vp:DiagramElementExtension>
				<vp:DiagramElementExtension Idref="ID_65415653_1601_7205_3007_204000200006">
					<vp:VpId Value="yb4rOB6FYHQgAQWV"/>
					<vp:ShapeType Value="BPPool"/>
					<vp:DiagramElementProperties>
						<vp:IntegerProperty Name="zOrder" Value="10"/>
						<vp:ModelRefProperty Name="metaModelElement">
							<vp:ModelRef Id="BP01" ModelType="BPPool" Name="Pool"/>
						</vp:ModelRefProperty>
						<vp:IntegerProperty Name="x" Value="30"/>
						<vp:IntegerProperty Name="y" Value="176"/>
						<vp:IntegerProperty Name="width" Value="728"/>
						<vp:IntegerProperty Name="height" Value="150"/>
						<vp:ColorProperty Name="background" Value="-8728587"/>
						<vp:ColorProperty Name="foreground" Value="-16777216"/>
						<vp:StringArrayProperty Name="customizedSortDiagramElementIds">
							<vp:Values>
								<vp:Value Value="ID_51415653_1601_7205_3007_204000200001"/>
								<vp:Value Value="ID_71415653_1601_7205_3007_204000200002"/>
								<vp:Value Value="ID_05415653_1601_7205_3007_204000200003"/>
								<vp:Value Value="ID_45415653_1601_7205_3007_204000200004"/>
								<vp:Value Value="ID_25415653_1601_7205_3007_204000200005"/>
							</vp:Values>
						</vp:StringArrayProperty>
						<vp:IntegerProperty Name="parentConnectorHeaderLength" Value="40"/>
						<vp:IntegerProperty Name="parentConnectorLineLength" Value="10"/>
						<vp:BooleanProperty Name="connectToPoint" Value="true"/>
						<vp:DoubleProperty Name="parentConnectorDTheta" Value="0.0"/>
						<vp:BooleanProperty Name="coverConnector" Value="false"/>
						<vp:BooleanProperty Name="requestDefaultSize" Value="false"/>
					</vp:DiagramElementProperties>
					<vp:ElementFont Color="-16777216" Name="Dialog" Size="11" Style="0"/>
					<vp:Line Cap="0" Color="-16777216" Transparency="0" Weight="1.0">
						<vp:Stroke/>
					</vp:Line>
					<vp:Caption Height="150" InternalHeight="-2147483648" InternalWidth="-2147483648" Side="8" Visible="true" Width="17" X="0" Y="0"/>
					<vp:FillColor Color1="-7873291" Style="1" Transparency="0" Type="1"/>
				</vp:DiagramElementExtension>
				<vp:DiagramElementExtension Idref="ID_65415653_1601_7205_3007_204000200007">
					<vp:VpId Value="fyErOB6FYHQgAQWb"/>
					<vp:ShapeType Value="BPPool"/>
					<vp:DiagramElementProperties>
						<vp:IntegerProperty Name="zOrder" Value="8"/>
						<vp:ModelRefProperty Name="metaModelElement">
							<vp:ModelRef Id="BP02" ModelType="BPPool" Name="Pool2"/>
						</vp:ModelRefProperty>
						<vp:IntegerProperty Name="x" Value="30"/>
						<vp:IntegerProperty Name="y" Value="394"/>
						<vp:IntegerProperty Name="width" Value="728"/>
						<vp:IntegerProperty Name="height" Value="150"/>
						<vp:ColorProperty Name="background" Value="-8728587"/>
						<vp:ColorProperty Name="foreground" Value="-16777216"/>
						<vp:IntegerProperty Name="parentConnectorHeaderLength" Value="40"/>
						<vp:IntegerProperty Name="parentConnectorLineLength" Value="10"/>
						<vp:BooleanProperty Name="connectToPoint" Value="true"/>
						<vp:DoubleProperty Name="parentConnectorDTheta" Value="0.0"/>
						<vp:BooleanProperty Name="coverConnector" Value="false"/>
						<vp:BooleanProperty Name="requestDefaultSize" Value="false"/>
					</vp:DiagramElementProperties>
					<vp:ElementFont Color="-16777216" Name="Dialog" Size="11" Style="0"/>
					<vp:Line Cap="0" Color="-16777216" Transparency="0" Weight="1.0">
						<vp:Stroke/>
					</vp:Line>
					<vp:Caption Height="150" InternalHeight="-2147483648" InternalWidth="-2147483648" Side="8" Visible="true" Width="17" X="0" Y="0"/>
					<vp:FillColor Color1="-7873291" Style="1" Transparency="0" Type="1"/>
				</vp:DiagramElementExtension>
			</vp:Extensions>
		</extensionElements>
		<participant id="BP01" name="Pool" processRef="process-BP01">
			<extensionElements>
				<vp:Extensions>
					<vp:ModelExtension>
						<vp:VpId Value="Kb4rOB6FYHQgAQWW"/>
						<vp:ModelType Value="BPPool"/>
						<vp:ModelProperties>
							<vp:StringProperty Name="pmCreateDateTime" Value="1615391391124"/>
							<vp:StringProperty Name="pmLastModified" Value="1615391434202"/>
							<vp:StringProperty Name="userID" Value="BP01"/>
							<vp:IntegerProperty Name="userIDLastNumericValue" Value="5"/>
						</vp:ModelProperties>
					</vp:ModelExtension>
				</vp:Extensions>
			</extensionElements>
		</participant>
		<participant id="BP02" name="Pool2" processRef="process-BP02">
			<extensionElements>
				<vp:Extensions>
					<vp:ModelExtension>
						<vp:VpId Value="fyErOB6FYHQgAQWc"/>
						<vp:ModelType Value="BPPool"/>
						<vp:ModelProperties>
							<vp:StringProperty Name="pmCreateDateTime" Value="1615391393022"/>
							<vp:StringProperty Name="pmLastModified" Value="1615391434203"/>
							<vp:StringProperty Name="userID" Value="BP02"/>
						</vp:ModelProperties>
					</vp:ModelExtension>
				</vp:Extensions>
			</extensionElements>
		</participant>
	</collaboration>
	<process id="process-BP01" isExecutable="false" name="Pool">
		<extensionElements/>
		<startEvent id="BP01_BP01" name="">
			<extensionElements>
				<vp:Extensions>
					<vp:ModelExtension>
						<vp:VpId Value="a_ErOB6FYHQgAQWl"/>
						<vp:ModelType Value="BPStartEvent"/>
						<vp:ParentRef Idref="BP01"/>
						<vp:ModelProperties>
							<vp:StringProperty Name="pmCreateDateTime" Value="1615391395798"/>
							<vp:StringProperty Name="pmLastModified" Value="1615391434198"/>
							<vp:StringProperty Name="userID" Value="BP01"/>
							<vp:StringProperty Name="userIDParent" Value="Kb4rOB6FYHQgAQWW"/>
						</vp:ModelProperties>
					</vp:ModelExtension>
				</vp:Extensions>
			</extensionElements>
			<outgoing>BP01_BP03</outgoing>
		</startEvent>
		<task completionQuantity="1" id="BP01_BP02" isForCompensation="false" name="Task" startQuantity="1">
			<extensionElements>
				<vp:bounds height="40" width="50" x="239" y="250"/>
				<vp:Extensions>
					<vp:ModelExtension>
						<vp:VpId Value="SZkrOB6FYHQgAQWu"/>
						<vp:ModelType Value="BPTask"/>
						<vp:ParentRef Idref="BP01"/>
						<vp:ModelProperties>
							<vp:StringProperty Name="pmCreateDateTime" Value="1615391398290"/>
							<vp:StringProperty Name="pmLastModified" Value="1615391434203"/>
							<vp:StringProperty Name="userID" Value="BP02"/>
							<vp:StringProperty Name="userIDParent" Value="Kb4rOB6FYHQgAQWW"/>
						</vp:ModelProperties>
					</vp:ModelExtension>
				</vp:Extensions>
			</extensionElements>
			<incoming>BP01_BP03</incoming>
			<outgoing>BP01_BP05</outgoing>
		</task>
		<sequenceFlow id="BP01_BP03" name="" sourceRef="BP01_BP01" targetRef="BP01_BP02">
			<extensionElements>
				<vp:Extensions>
					<vp:ModelExtension>
						<vp:VpId Value="_fkrOB6FYHQgAQXA"/>
						<vp:ModelType Value="BPSequenceFlow"/>
						<vp:ParentRef/>
						<vp:ModelProperties>
							<vp:StringProperty Name="pmCreateDateTime" Value="1615391399871"/>
							<vp:StringProperty Name="pmLastModified" Value="1615391434198"/>
							<vp:StringProperty Name="userID" Value="BP03"/>
							<vp:StringProperty Name="userIDParent" Value="Kb4rOB6FYHQgAQWW"/>
						</vp:ModelProperties>
					</vp:ModelExtension>
				</vp:Extensions>
			</extensionElements>
		</sequenceFlow>
		<endEvent id="BP01_BP04" name="">
			<extensionElements>
				<vp:Extensions>
					<vp:ModelExtension>
						<vp:VpId Value="jJUrOB6FYHQgAQXO"/>
						<vp:ModelType Value="BPEndEvent"/>
						<vp:ParentRef Idref="BP01"/>
						<vp:ModelProperties>
							<vp:StringProperty Name="pmCreateDateTime" Value="1615391402289"/>
							<vp:StringProperty Name="pmLastModified" Value="1615391434202"/>
							<vp:StringProperty Name="userID" Value="BP04"/>
							<vp:StringProperty Name="userIDParent" Value="Kb4rOB6FYHQgAQWW"/>
						</vp:ModelProperties>
					</vp:ModelExtension>
				</vp:Extensions>
			</extensionElements>
			<incoming>BP01_BP05</incoming>
		</endEvent>
		<sequenceFlow id="BP01_BP05" name="" sourceRef="BP01_BP02" targetRef="BP01_BP04">
			<extensionElements>
				<vp:Extensions>
					<vp:ModelExtension>
						<vp:VpId Value="c_UrOB6FYHQgAQXd"/>
						<vp:ModelType Value="BPSequenceFlow"/>
						<vp:ParentRef/>
						<vp:ModelProperties>
							<vp:StringProperty Name="pmCreateDateTime" Value="1615391403982"/>
							<vp:StringProperty Name="pmLastModified" Value="1615391434202"/>
							<vp:StringProperty Name="userID" Value="BP05"/>
							<vp:StringProperty Name="userIDParent" Value="Kb4rOB6FYHQgAQWW"/>
						</vp:ModelProperties>
					</vp:ModelExtension>
				</vp:Extensions>
			</extensionElements>
		</sequenceFlow>
	</process>
	<process id="process-BP02" isExecutable="false" name="Pool2"/>
	<bpmndi:BPMNDiagram id="diagram-_1" name="Business Process Diagram1">
		<bpmndi:BPMNPlane bpmnElement="collaboration-_1" id="plane-_1">
			<bpmndi:BPMNShape bpmnElement="BP01_BP01" id="ID_51415653_1601_7205_3007_204000200001">
				<omgdc:Bounds height="20" width="20" x="122" y="227"/>
			</bpmndi:BPMNShape>
			<bpmndi:BPMNShape bpmnElement="BP01_BP02" id="ID_71415653_1601_7205_3007_204000200002">
				<omgdc:Bounds height="40" width="50" x="239" y="250"/>
			</bpmndi:BPMNShape>
			<bpmndi:BPMNEdge bpmnElement="BP01_BP03" id="ID_05415653_1601_7205_3007_204000200003">
				<omgdi:waypoint x="132" y="247"/>
				<omgdi:waypoint x="132" y="270"/>
				<omgdi:waypoint x="238" y="270"/>
			</bpmndi:BPMNEdge>
			<bpmndi:BPMNShape bpmnElement="BP01_BP04" id="ID_45415653_1601_7205_3007_204000200004">
				<omgdc:Bounds height="20" width="20" x="381" y="278"/>
			</bpmndi:BPMNShape>
			<bpmndi:BPMNEdge bpmnElement="BP01_BP05" id="ID_25415653_1601_7205_3007_204000200005">
				<omgdi:waypoint x="289" y="270"/>
				<omgdi:waypoint x="390" y="270"/>
				<omgdi:waypoint x="390" y="278"/>
			</bpmndi:BPMNEdge>
			<bpmndi:BPMNShape bpmnElement="BP01" id="ID_65415653_1601_7205_3007_204000200006" isHorizontal="true">
				<omgdc:Bounds height="150" width="728" x="30" y="176"/>
			</bpmndi:BPMNShape>
			<bpmndi:BPMNShape bpmnElement="BP02" id="ID_65415653_1601_7205_3007_204000200007" isHorizontal="true">
				<omgdc:Bounds height="150" width="728" x="30" y="394"/>
			</bpmndi:BPMNShape>
		</bpmndi:BPMNPlane>
	</bpmndi:BPMNDiagram>
</definitions>

mteodori · 2021-03-10T21:59:57Z

Thanks for your submission.
In order to accept, please provide a unit test and reference to the BPMN documentation and schema where this is detailed

XenoAmess · 2021-03-11T15:38:37Z

Thanks for your submission.
In order to accept, please provide a unit test and reference to the BPMN documentation and schema where this is detailed

BPMN documentation : https://www.omg.org/spec/BPMN/20100501/Semantic.xsd
this bpmn file is generated by visual paradigm BTW.

XenoAmess · 2021-03-11T15:43:01Z

@mteodori Unit Test added. please re-review. thanks.

.../test/java/org/activiti/editor/language/xml/CollaborationExtensionElementsConverterTest.java

XenoAmess · 2021-04-06T18:03:50Z

@erdemedeiros related issue created at #3623

erdemedeiros

Thank you, @XenoAmess!

XenoAmess force-pushed the fix_NPE_when_parsing_some_leagal_bpmn_xml_files_ branch from cf62330 to 22906f3 Compare March 11, 2021 15:42

XenoAmess force-pushed the fix_NPE_when_parsing_some_leagal_bpmn_xml_files_ branch from 22906f3 to 09f9a54 Compare March 11, 2021 15:49

erdemedeiros requested changes Apr 6, 2021

View reviewed changes

.../test/java/org/activiti/editor/language/xml/CollaborationExtensionElementsConverterTest.java Show resolved Hide resolved

XenoAmess force-pushed the fix_NPE_when_parsing_some_leagal_bpmn_xml_files_ branch 2 times, most recently from c08c858 to 5669f3c Compare April 6, 2021 18:01

XenoAmess added 2 commits April 7, 2021 02:01

fix NPE when parsing some legal bpmn xml files

9ecae45

refine unit test

83308ea

XenoAmess force-pushed the fix_NPE_when_parsing_some_leagal_bpmn_xml_files_ branch from 5669f3c to 83308ea Compare April 6, 2021 18:01

XenoAmess mentioned this pull request Apr 6, 2021

[bug]fix NPE when parsing some legal bpmn xml files #3623

Closed

XenoAmess requested a review from erdemedeiros April 6, 2021 18:16

erdemedeiros approved these changes Apr 7, 2021

View reviewed changes

mergify bot merged commit 1237f94 into Activiti:develop Apr 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bug-fix]fix NPE when parsing some legal bpmn xml files#3588

[bug-fix]fix NPE when parsing some legal bpmn xml files#3588
mergify[bot] merged 2 commits intoActiviti:developfrom
xenoamess-fork:fix_NPE_when_parsing_some_leagal_bpmn_xml_files_

XenoAmess commented Mar 8, 2021

Uh oh!

codecov bot commented Mar 8, 2021 •

edited

Loading

Uh oh!

XenoAmess commented Mar 10, 2021

Uh oh!

mteodori commented Mar 10, 2021

Uh oh!

XenoAmess commented Mar 11, 2021 •

edited

Loading

Uh oh!

XenoAmess commented Mar 11, 2021

Uh oh!

Uh oh!

XenoAmess commented Apr 6, 2021

Uh oh!

erdemedeiros left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

XenoAmess commented Mar 8, 2021

Uh oh!

codecov bot commented Mar 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

XenoAmess commented Mar 10, 2021

Uh oh!

mteodori commented Mar 10, 2021

Uh oh!

XenoAmess commented Mar 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

XenoAmess commented Mar 11, 2021

Uh oh!

Uh oh!

XenoAmess commented Apr 6, 2021

Uh oh!

erdemedeiros left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Mar 8, 2021 •

edited

Loading

XenoAmess commented Mar 11, 2021 •

edited

Loading