remove javaagent from start scripts #734

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@smirzai
Contributor
smirzai commented Nov 14, 2015

I think not every body has jrebels jar files on his machine.

@jbarrez
Contributor
jbarrez commented Nov 14, 2015

Would it be possible to have two versions of the start scripts? So those people that do have can use it ;-)

Joram

Sent from a mobile device, pls excuse brevity

On 14 Nov 2015, at 18:03, Saeid Mirzaei notifications@github.com wrote:

I think not every body has jrebels jar files on his machine.

You can view, comment on, or merge this pull request online at:

#734

Commit Summary

remove javaagent from start scripts
File Changes

M scripts/start-dev-tomcat.sh (10)
M scripts/start-explorer.sh (6)
M scripts/start-rest.sh (6)
Patch Links:

https://github.com/Activiti/Activiti/pull/734.patch
https://github.com/Activiti/Activiti/pull/734.diff

Reply to this email directly or view it on GitHub.

@smirzai
Contributor
smirzai commented Nov 14, 2015

hi Joram,
even in that case, do you think they should install it the same place as
that some others you just mentioned.
How about have one script, default to no agent, with an additional switch
for the agent owners (with the fix path for the agent file, of course).
Making the agent dynamic, is not much necessary I think. Because nobody has
complained so far.

Saeid

On Sat, Nov 14, 2015 at 8:31 PM, Joram Barrez notifications@github.com
wrote:

Would it be possible to have two versions of the start scripts? So those
people that do have can use it ;-)

Joram

Sent from a mobile device, pls excuse brevity

On 14 Nov 2015, at 18:03, Saeid Mirzaei notifications@github.com
wrote:

I think not every body has jrebels jar files on his machine.

You can view, comment on, or merge this pull request online at:

#734

Commit Summary

remove javaagent from start scripts
File Changes

M scripts/start-dev-tomcat.sh (10)
M scripts/start-explorer.sh (6)
M scripts/start-rest.sh (6)
Patch Links:

https://github.com/Activiti/Activiti/pull/734.patch
https://github.com/Activiti/Activiti/pull/734.diff

Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#734 (comment).

@jbarrez
Contributor
jbarrez commented Nov 14, 2015

Indeed, i think not many people run it, or we would have heard complaints. I prefer two different scripts, mainly because im lazy and want to use my terminal autocomplete rather than typing the extra param.

This is for dev only, so having a bit more scripts doesnt hurt.

Joram

Sent from a mobile device, pls excuse brevity

On 14 Nov 2015, at 20:37, Saeid Mirzaei notifications@github.com wrote:

hi Joram,
even in that case, do you think they should install it the same place as
that some others you just mentioned.
How about have one script, default to no agent, with an additional switch
for the agent owners (with the fix path for the agent file, of course).
Making the agent dynamic, is not much necessary I think. Because nobody has
complained so far.

Saeid

On Sat, Nov 14, 2015 at 8:31 PM, Joram Barrez notifications@github.com
wrote:

Would it be possible to have two versions of the start scripts? So those
people that do have can use it ;-)

Joram

Sent from a mobile device, pls excuse brevity

On 14 Nov 2015, at 18:03, Saeid Mirzaei notifications@github.com
wrote:

I think not every body has jrebels jar files on his machine.

You can view, comment on, or merge this pull request online at:

#734

Commit Summary

remove javaagent from start scripts
File Changes

M scripts/start-dev-tomcat.sh (10)
M scripts/start-explorer.sh (6)
M scripts/start-rest.sh (6)
Patch Links:

https://github.com/Activiti/Activiti/pull/734.patch
https://github.com/Activiti/Activiti/pull/734.diff

Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#734 (comment).


Reply to this email directly or view it on GitHub.

@tijsrademakers
Contributor

Added scripts that don't require JRebel

@smirzai smirzai deleted the smirzai:removeAgentFromStartBrowser branch Nov 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment