New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add process runtime context attributes in RuntimeEvent api #35

Merged
merged 3 commits into from Nov 13, 2018

Conversation

Projects
None yet
2 participants
@igdianov
Member

igdianov commented Nov 13, 2018

This PR proposes to fix Activiti/Activiti#2069 by adding important process run-time context attributes such as processDefinitionId, processDefinitionKey, processDefinitionVersion, businessKey in order to enable consumers to apply event correlation with business context for RuntimeEvent and IntegrationContext.

The provided setters in RuntimeEventImpl and IntegrationContextImpl classes will allow to inject process runtime context attributes in runtime bundle events aggregator and converter modules.

We need to review and discuss if there are any additional attributes can be useful for downstream consumption such as deploymentId, processName, superProcessInstanceId, superProcessInstanceName. These attributes can be injected as message headers by events aggregator.

The implementation is non-invasive by keeping the existing class constructors intact, which makes events mutable. The best practice is to make event instances immutable to avoid any potential side effects later. We need to discuss pros and cons of the approach...

@igdianov igdianov self-assigned this Nov 13, 2018

@igdianov igdianov requested a review from erdemedeiros Nov 13, 2018

@salaboy salaboy added the in progress label Nov 13, 2018

@salaboy salaboy merged commit f65e7aa into develop Nov 13, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@salaboy salaboy removed the in progress label Nov 13, 2018

@salaboy salaboy deleted the igdianov-2069-runtime-context-events-api branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment