New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing processInstanceId in RuntimeEvent api #37

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
3 participants
@igdianov
Member

igdianov commented Nov 14, 2018

This PR adds missing processInstanceId attribute in RuntimeEvent interface and RuntimeEventImpl

This is useful to correlate events to be able to issue commands with processInstanceId from any RuntimeEvent similar to IntegrationContext which has processInstanceId attribute.

Fixes Activiti/Activiti#2069

@igdianov igdianov self-assigned this Nov 14, 2018

@igdianov igdianov requested a review from salaboy Nov 14, 2018

@salaboy salaboy added the in progress label Nov 14, 2018

@salaboy

This comment has been minimized.

Member

salaboy commented Nov 14, 2018

@erdemedeiros @igdianov We need to be careful here to not just add everything that we think that we might need. ProcessInstanceId sounds like a good thing to add here.. but if we add processInstanceId we will probably need also parentProcessInstanceId as well? Am I right?
Also we will need to clean up our CloudRuntimeEvents which are extending this RuntimeEvents and decorating them with more data, to make sure that we don't duplicate data. In other words, if we add this field here.. we need to make sure that it is not in CloudRuntimeEvents.

@salaboy

@igdianov I need @erdemedeiros input on this one as well.

@salaboy salaboy requested a review from erdemedeiros Nov 14, 2018

@erdemedeiros

I think it's fine to have this field here. And yes we'll need to add the rootProcessInstanceId as well once we have it in the API.

@erdemedeiros erdemedeiros merged commit c187f06 into develop Nov 14, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@erdemedeiros erdemedeiros deleted the igdianov-2069-process-instance-api branch Nov 14, 2018

@salaboy salaboy removed the in progress label Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment